292440 - Cannot rate an extension with zero stars

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Philip Chee]

User-Agent:       Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.8a6) Gecko/20050111 MultiZilla/1.8.0.0a Mnenhy/0.7.2.0
Build Identifier: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.8a6) Gecko/20050111 MultiZilla/1.8.0.0a Mnenhy/0.7.2.0

Error Message:

Mozilla Update has encountered an error and is unable to fulfill your request.
Please try your request again later. If the problem continues, please contact
the Mozilla Update staff. More information about the error may be found at the
end of this message.

Error 3: Comment is Blank or Rating is Null.

<https://bugzilla.mozilla.org/show_bug.cgi?id=246753#c4>
Says that this has been fixed.  Regression?


Reproducible: Always

Steps to Reproduce:

Comment 1

[Jason Chu]

Looks like an extraneous check for !$rating (true when $rating = 0) at
http://lxr.mozilla.org/mozilla/source/webtools/update/core/postfeedback.php#71

Comment 2

[alanjstr]

*** Bug 294097 has been marked as a duplicate of this bug. ***

Comment 3

[Jon Stritar]

Attachment: a small patch

haven't tested it .. no dev environment

Comment 4

[Jon Stritar]

Attachment: a patch that you should be able to apply

You should be able to apply this one.. same changes but made the patch a
different way.

Comment 5

[Colin Ogilvie [:cso]]

Comment on attachment 185988 [details] [diff] [review]
a patch that you should be able to apply

r=me and it seemed to work in testing.

Comment 6

[Jon Stritar]

Is this working for you guys on http://addons.mozilla.org? Its not for me..