292508 - Can no longer drag & drop bookmarks in Bookmark Bar

Status: RESOLVED FIXED

(Camino Graveyard :: Drag & Drop, defect)

Description

[John Sawyer]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050419 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050419 Camino/0.8+

I can no longer drag and drop bookmarks in the Bookmark Bar, to reorder them.  I
used to be able to drag bookmarks to place them inbetween other bookmarks, where
a vertical insertion bar would appear indicating it was ready to receive the
dragged bookmark at that location.  However, now no insertion bar appears, and
trying to drop the bookmark inbetween two other bookmarks anyway, doesn't result
in the bookmark being moved to that location.  Was this feature simply removed?
 The only way now to rearrange bookmarks in the Bookmark Bar is to use the
Bookmarks window, which is less convenient.

Reproducible: Always

Steps to Reproduce:
1. Drag an icon in the Bookmark Bar to a spot between two other bookmarks.
2. Look for a vertical insertion bar at the new desired location.
Actual Results:  
No vertical insertion bar.

Expected Results:  
Should be a vertical insertion bar.

Comment 1

[Josh Aas]

what os version?

Comment 2

[Jasper]

On all, I saw this bug quiet a while ago but I talked with Bruce about it. My
gut tells me it has to do with the pasterboard patch from Bruce, but I'm not sure.

Comment 3

[L. H.]

Worked in 4/08 nightly but not in 4/13 nightly

Comment 4

[Jasper]

So in that timefrane patches for bug 155484 and bug 287118 landed, Bruce should
takea good look at what happened.

Comment 5

[John Sawyer]

OS 10.3.8 and 10.3.9

Comment 6

[Bruce Davidson]

Accepting this one - fallout from my bookmark D&D changes. Patch coming up.

Comment 7

[Bruce Davidson]

Attachment: Patch

My previous change under bug 155484 did all the preparation for working out
whether the drop was valid, but forgot to ever return the result of this work!
Oops! This fixes it, and makes the logic clearer than the previous working
code.

Requesting review.

Comment 8

[Wevah (Nate Weaver)]

Comment on attachment 182781 [details] [diff] [review]
Patch

Looks good to me. Don't really need the final |else| since you return before it
in the |if|, but ti doesn't really matter.

r+

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 182781 [details] [diff] [review]
Patch

sr=pink

agreed, shouldn't have last |else| after return. I removed it when i checked
in.

Comment 10

[Mike Pinkerton (not reading bugmail)]

landed.