Inline spellchecker crashes unless the document is checked first

RESOLVED FIXED in mozilla1.8beta3

Status

()

--
critical
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: neil, Assigned: neil)

Tracking

({crash})

Trunk
mozilla1.8beta3
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
If you assume that the existing document has already been spell checked and you
just turn on inline spell checking then it soon crashes. This is because only
checking the document will create its internal spelling utility converter.
(Assignee)

Comment 1

14 years ago
Created attachment 182325 [details] [diff] [review]
Proposed patch

This factors out the creation of the converter into a separate method and calls
it in the two places required. A couple of unused variables are also removed.
(Assignee)

Updated

14 years ago
Assignee: mscott → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #182325 - Flags: superreview?(mscott)
Attachment #182325 - Flags: review?(daniel)

Updated

14 years ago
Attachment #182325 - Flags: superreview?(mscott) → superreview+
fwding to Neil Deakin who should r= this patch.
(Assignee)

Updated

14 years ago
Attachment #182325 - Flags: review?(daniel) → review?(enndeakin)

Comment 3

14 years ago
The patch looks fine to me, but I'm not a module owner/peer nor did I write the
original code, so I don't think my review would count.
Original author of that code seems to be scott mac gregor.
(Assignee)

Comment 5

14 years ago
Comment on attachment 182325 [details] [diff] [review]
Proposed patch

Sorry for the pass-the-parcel, would you mind upgrading to r+sr?
Attachment #182325 - Flags: review?(enndeakin) → review?(mscott)

Comment 6

14 years ago
Comment on attachment 182325 [details] [diff] [review]
Proposed patch

sure
Attachment #182325 - Flags: review?(mscott) → review+
(Assignee)

Comment 7

14 years ago
Comment on attachment 182325 [details] [diff] [review]
Proposed patch

Although this is a crash fix we are currently working around it in the UI, so
it's not desperately urgent.
Attachment #182325 - Flags: approval1.8b3?
Attachment #182325 - Flags: approval1.8b2?

Comment 8

14 years ago
Comment on attachment 182325 [details] [diff] [review]
Proposed patch

moving request out to b3. We're very nearly wrapped up on 1.8b2.
Attachment #182325 - Flags: approval1.8b2? → approval1.8b2-
Comment on attachment 182325 [details] [diff] [review]
Proposed patch

a=shaver
Attachment #182325 - Flags: approval1.8b3? → approval1.8b3+
(Assignee)

Comment 10

14 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Blocks: 287540
Target Milestone: --- → mozilla1.8beta3
You need to log in before you can comment on or make changes to this bug.