Closed Bug 292520 Opened 19 years ago Closed 19 years ago

Inline spellchecker crashes unless the document is checked first

Categories

(Core :: Spelling checker, defect)

Product:
Core
Component:
Spelling checker
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8beta3

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: crash)

Attachments

(1 file)

Proposed patch
3.93 KB, patch
mscott
: review+
mscott
: superreview+
asa
: approval1.8b2-
shaver
: approval1.8b3+
Details | Diff | Splinter Review 
If you assume that the existing document has already been spell checked and you
just turn on inline spell checking then it soon crashes. This is because only
checking the document will create its internal spelling utility converter.
Attached patch Proposed patch — — Splinter Review 
This factors out the creation of the converter into a separate method and calls
it in the two places required. A couple of unused variables are also removed.
Assignee: mscott → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #182325 - Flags: superreview?(mscott)
Attachment #182325 - Flags: review?(daniel)
Attachment #182325 - Flags: superreview?(mscott) → superreview+
fwding to Neil Deakin who should r= this patch.
Attachment #182325 - Flags: review?(daniel) → review?(enndeakin)
The patch looks fine to me, but I'm not a module owner/peer nor did I write the
original code, so I don't think my review would count.
Original author of that code seems to be scott mac gregor.
Comment on attachment 182325 [details] [diff] [review]
Proposed patch

Sorry for the pass-the-parcel, would you mind upgrading to r+sr?
Attachment #182325 - Flags: review?(enndeakin) → review?(mscott)
Comment on attachment 182325 [details] [diff] [review]
Proposed patch

sure
Attachment #182325 - Flags: review?(mscott) → review+
Comment on attachment 182325 [details] [diff] [review]
Proposed patch

Although this is a crash fix we are currently working around it in the UI, so
it's not desperately urgent.
Attachment #182325 - Flags: approval1.8b3?
Attachment #182325 - Flags: approval1.8b2?
Comment on attachment 182325 [details] [diff] [review]
Proposed patch

moving request out to b3. We're very nearly wrapped up on 1.8b2.
Attachment #182325 - Flags: approval1.8b2? → approval1.8b2-
Comment on attachment 182325 [details] [diff] [review]
Proposed patch

a=shaver
Attachment #182325 - Flags: approval1.8b3? → approval1.8b3+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Blocks: 287540
Target Milestone: --- → mozilla1.8beta3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: