292525 - Drag and drop between 2 live bookmarks (Bookmarked RSS feeds) does not work

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect)

Description

[Prakash Mehrotra]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3

I tried searching a lot for this bug, but unfortunately could not find one which
matched my observation.

The observed problem happens when a bookmark (folder, single link or live
bookmark) is dragged and attempted to be dropped between 2 LIVE BOOKMARKS.
2. It happens for DND attempted in both the BM menu as well as the BM toolbar.

Since this is a bit strange, let me describe using an example. Lets assume I
have this bookmark list as seen in my bookmarks menu:

.
.
.
BM1
BM FOLDER1
BM FOLDER2
BM2
LIVE BM1
LIVE BM2
LIVE BM3
BM3
LIVE BM4
.
.
.

All kind of DND works, except for drops between:
1. 'LIVE BM1' & 'LIVE BM2'
2. 'LIVE BM2' & 'LIVE BM3'







Reproducible: Always

Steps to Reproduce:
Please see details.
Actual Results:  
Cannot drop bookmarks between:
1. 'LIVE BM1' & 'LIVE BM2'
2. 'LIVE BM2' & 'LIVE BM3'


Expected Results:  
Bookmarks should be droppable between:
1. 'LIVE BM1' & 'LIVE BM2'
2. 'LIVE BM2' & 'LIVE BM3'

Comment 1

[Phil Ringnalda (:philor)]

That's from Vlad's patch in bug 256362 (works in 20040823, fails in 20040826),
though since it's trees, and the tree API for DnD had already changed on the
trunk in bug 221619 so the aviary-landing landed on something a bit different,
I'm not sure how to fix it.

Comment 2

[Phil Ringnalda (:philor)]

*** Bug 308457 has been marked as a duplicate of this bug. ***

Comment 3

[Allan]

I was just going to file a bug report on this - hope someone fixes it!  Note that this problem is not experienced while in the bookmark manager, only from within the bookmarks menu in firefox.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Maybe seth has time to take a look?

Comment 5

[(not reading, please use [e-mail] instead)]

I am able to reproduce this with my bon echo build [Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060706 BonEcho/2.0a3], but it sounds like it has been there for a while.

for me, I get the "can't drop" drag indicator.

cc'ing jminta, who gets jealous any time someone touches the non-places bookmarks code.

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: start of a patch, still more to do.

Comment 7

[(not reading, please use [e-mail] instead)]

the plan here is to make it so for the bookmarks dnd code, we treat livebookmarks like regular bookmarks.

part of the fix is to canDrop(), so that for Livemarks, we don't show the "can't drop" icon.

also make it so that for livemarks (both on the personal toolbar folder and in the bookmarks menu) we don't treat the livemarks like a container, and allow you to drop in them (or auto expand open).

but there is more work to be done, as such as:

when dragging over a livemark item in the menus or in the personal toolbar folder, we still give the UI feedback that you can drop the bookmark into the livemark folder.  we it should not do that.  (same for in the manage bookmarks dialog.)

note, this fix would be branch only, as the trunk uses places. 

Comment 8

[(not reading, please use [e-mail] instead)]

I think the next piece to fix is getBTOrientation(), and to make sure for livemarks, we don't return BookmarksUtils.DROP_ON.

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: start of a patch, still more to do.

Comment 10

[(not reading, please use [e-mail] instead)]

sorry for the bug spam, re-assigning bugs back to default owner if I'm not working actively on them.

Comment 11

[Marco Bonardo [:mak]]

drop inside live bookmarks should not (and is not) allowed on current trunk
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20081215 Minefield/3.2a1pre