Closed Bug 292540 Opened 20 years ago Closed 19 years ago

Incorrect check of PR_Malloc failure in nsScriptSecurityManager.cpp ligne 3277

Categories

(Core :: Security: CAPS, defect)

Product:
Core
Component:
Security: CAPS
Platform:
x86
Other
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: manuel.leclerc, Assigned: dveditz)

References

Details

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows 98; KITV4.6 Wanadoo)
Build Identifier: 

Actual Code (Firefox 1.0.3) :

*grantedPref = (char)PR_MALLOC(prefLen + sizeof(granted));
if (!grantedPref) return NS_ERROR_OUT_OF_MEMORY;

It's a "typo". The check sould be :
if (!*grantedPref) return NS_ERROR_OUT_OF_MEMORY;


Reproducible: Always
http://lxr.mozilla.org/mozilla/source/caps/src/nsScriptSecurityManager.cpp#3210 ?

No idea where this goes, but it's not Firefox: General and CAPS is in the
filename in LXR, so... -> Core: Security: CAPS
Assignee: nobody → dveditz
Component: General → Security: CAPS
Product: Firefox → Core
QA Contact: general
Version: unspecified → Trunk
Similarly deniedPref
Status: UNCONFIRMED → NEW
Ever confirmed: true
The patch in bug 240661 removes this code altogether...
Depends on: 240661
Fixed by checkin for bug 240661.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.