292634 - We don't handle ref="ns:type" in schema code.

Status: RESOLVED FIXED

(Core Graveyard :: Web Services, defect)

Description

[Doron Rosenberg (IBM)]

nsSchemaElementRef::Resolve simply calls mSchema->GetElementByName(mRef,
getter_AddRefs(mElement));, and doesn't take ns:type as a ref value into
consideration.

Comment 1

[Doron Rosenberg (IBM)]

Attachment: patch - store the namespace in nsSchemaElementRef

Comment 2

[Doron Rosenberg (IBM)]

Found this working on complex type validation.  It would throw an exception when
trying to call nsISchemaParticle->GetName() for example.

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 182406 [details] [diff] [review]
patch - store the namespace in nsSchemaElementRef

>Index: extensions/webservices/schema/src/nsSchemaLoader.cpp
>===================================================================

>@@ -992,8 +993,36 @@
>   aElement->GetAttribute(NS_LITERAL_STRING("ref"), ref);
>   if (!ref.IsEmpty()) {
>     nsSchemaElementRef* elementRef;
>-    
>-    elementRef = new nsSchemaElementRef(aSchema, ref);
>+    nsAutoString refNS;
>+
>+    if (ref.FindChar(':') != kNotFound) {

I didn't really find in the spec if there's a default namespace (for unprefixed
ref attribute values), do you know?
I think we should always call CheckQName and only look up the namespace URI if
colon is non-null, what do you think?

Comment 4

[Doron Rosenberg (IBM)]

(In reply to comment #3)
> (From update of attachment 182406 [details] [diff] [review] [edit])
> >Index: extensions/webservices/schema/src/nsSchemaLoader.cpp
> >===================================================================
> 
> >@@ -992,8 +993,36 @@
> >   aElement->GetAttribute(NS_LITERAL_STRING("ref"), ref);
> >   if (!ref.IsEmpty()) {
> >     nsSchemaElementRef* elementRef;
> >-    
> >-    elementRef = new nsSchemaElementRef(aSchema, ref);
> >+    nsAutoString refNS;
> >+
> >+    if (ref.FindChar(':') != kNotFound) {
> 
> I didn't really find in the spec if there's a default namespace (for unprefixed
> ref attribute values), do you know?

From what I can tell, it seems to imply that no ns: means current schema
document.  The samples and schema files I have seen seem to impyl this as well.

> I think we should always call CheckQName and only look up the namespace URI if
> colon is non-null, what do you think?
> 

You are probably right, FindChar in the case of no ns: means it has to walk the
whole string.  And if ns: exists, we go through some part of the string and then
through it again in CheckQName() probably.

Do I need a r= for this as well?

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 182406 [details] [diff] [review]
patch - store the namespace in nsSchemaElementRef

r/sr=peterv with change to always call CheckQName.

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 182406 [details] [diff] [review]
patch - store the namespace in nsSchemaElementRef

a=mkaply

Comment 7

[Doron Rosenberg (IBM)]

checked in!