Closed Bug 292671 Opened 20 years ago Closed 20 years ago

Code reading shows we can simplify one function

Categories

(Camino Graveyard :: Location Bar & Autocomplete, enhancement)

Product:
Camino Graveyard
Component:
Location Bar & Autocomplete
Platform:
PowerPC
macOS
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Usul, Assigned: Usul)

References

(
URL
)

Details

Attachments

(1 file)

patch simplifying the computation of the /favicon.ico url
887 bytes, patch
mozilla
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review 
While reading SiteIconProvider.mm I saw a piece of code that could be simplified.
Patch simplifying the code coming up.
asking review to bruce
Assignee: pinkerton → qa-mozilla
Status: NEW → ASSIGNED
Attachment #182433 - Flags: review?(Bruce.Davidson)
Comment on attachment 182433 [details] [diff] [review]
patch simplifying the computation of the /favicon.ico url

Applies cleanly - patch makes sense - works. r=me
Attachment #182433 - Flags: review?(Bruce.Davidson) → review+
Attachment #182433 - Flags: superreview?(pinkerton)
Comment on attachment 182433 [details] [diff] [review]
patch simplifying the computation of the /favicon.ico url

sr=pink
Attachment #182433 - Flags: superreview?(pinkerton) → superreview+
landed
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: