292676 - make composite calendar persist its membership and default-calendar settings

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Mike Shaver (:shaver emeritus)]

I want to teach the composite calendar to take a "preference prefix" from its
creator, and then initialize/track changes to its membership and default
settings.    In fact, I have done that teaching.  Patch coming up.

Comment 1

[Mike Shaver (:shaver emeritus)]

Attachment: store $pref-in-composite and $pref-default in the calmgr prefs

So one thing about this patch that might not quite be right is that we don't
persist the "implicit" default setting that comes from being the first calendar
added.	So if you get the calendars back in a different order later, the first
one added is the new default, again.  I think that's fine -- if you want an
explicit default, please to be asking for it! -- but someone else might not.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 182437 [details] [diff] [review]
store $pref-in-composite and $pref-default in the  calmgr prefs

Please remove one of the two notifyObservers function definitions, but other
than that r=vladimir

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

nm on the removal, didn't see there were 2 separate classes in the diff

Comment 4

[Mike Shaver (:shaver emeritus)]

Fixed, way to read the diff!