292710 - Submit bound to empty nodeset fails

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Allan Beaufour]

If a submit is triggered for a submission with @ref that returns no nodes,
nothing is submitted and the submit button is left disabled.

Comment 1

[Allan Beaufour]

Attachment: Testcase

Comment 2

[aaronr]

I don't get what is supposed to happen.  Can you describe what should happen? 
Not immediately apparent with your testcases.  Thanks.

Comment 3

[Allan Beaufour]

(In reply to comment #2)
> I don't get what is supposed to happen.  Can you describe what should happen?

Exactly what is submitted ... I dunno? But the submit button should not stay
disabled. The instance data could be modified so that @ref points at something
valid.

Comment 4

[Allan Beaufour]

Attachment: Testcase v2

Here's a better testcase, showing and explaining the problem. I suspect the
previous wasn't clear enough.

Comment 5

[Allan Beaufour]

(In reply to comment #4)
> Here's a better testcase, showing and explaining the problem. I suspect the
> previous wasn't clear enough.

Problem is, besides that the button should stay disabled, what exactly should
happen to a submission with an empty nodeset. I cannot find it in the spec. Can
any of you?

Comment 6

[aaronr]

Nope, I don't see anything in the spec or errata about it.  I just see what
should happen with an invalid nodeset or a required-but-empty nodeset.  I would
say that if the button is enabled to allow the empty submission the first time,
it should be enabled the whole way through and not go disabled and stay that
way.  Even if we allow it to stayed grayed, either way should have a message in
the JS Console but only if we DON'T submit anything.  If we end up finding that
we should be submitting, but submitting nothing, then probably shouldn't put a
message in the console.

Comment 7

[Allan Beaufour]

Contacted the WG:
http://lists.w3.org/Archives/Member/w3c-forms/2005JulSep/0106.html

Comment 8

[Allan Beaufour]

(In reply to comment #7)
> Contacted the WG:
> http://lists.w3.org/Archives/Member/w3c-forms/2005JulSep/0106.html

Has just been resolved. We should dispatch an xforms-submit-error.

Comment 9

[Allan Beaufour]

Attachment: Patch

Created EndSubmit() which enables the activator, and dispatches the event. This
is then called if do data is available.

Comment 10

[Allan Beaufour]

Checked in to trunk

Comment 11

[aaronr]

checked into branch 20051004