Closed Bug 292710 Opened 16 years ago Closed 15 years ago

Submit bound to empty nodeset fails

Categories

(Core Graveyard :: XForms, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: allan, Assigned: allan)

References

()

Details

(Keywords: fixed1.8, testcase)

Attachments

(2 files, 1 obsolete file)

1.74 KB, application/xhtml+xml
Details
3.95 KB, patch
doronr
: review+
smaug
: review+
Details | Diff | Splinter Review
If a submit is triggered for a submission with @ref that returns no nodes,
nothing is submitted and the submit button is left disabled.
Attached file Testcase (obsolete) —
I don't get what is supposed to happen.  Can you describe what should happen? 
Not immediately apparent with your testcases.  Thanks.
(In reply to comment #2)
> I don't get what is supposed to happen.  Can you describe what should happen?

Exactly what is submitted ... I dunno? But the submit button should not stay
disabled. The instance data could be modified so that @ref points at something
valid.
Summary: Submit with unbound ref fails → Submit bound to empty nodeset fails
Attached file Testcase v2
Here's a better testcase, showing and explaining the problem. I suspect the
previous wasn't clear enough.
Attachment #182480 - Attachment is obsolete: true
(In reply to comment #4)
> Here's a better testcase, showing and explaining the problem. I suspect the
> previous wasn't clear enough.

Problem is, besides that the button should stay disabled, what exactly should
happen to a submission with an empty nodeset. I cannot find it in the spec. Can
any of you?
Keywords: testcase
Nope, I don't see anything in the spec or errata about it.  I just see what
should happen with an invalid nodeset or a required-but-empty nodeset.  I would
say that if the button is enabled to allow the empty submission the first time,
it should be enabled the whole way through and not go disabled and stay that
way.  Even if we allow it to stayed grayed, either way should have a message in
the JS Console but only if we DON'T submit anything.  If we end up finding that
we should be submitting, but submitting nothing, then probably shouldn't put a
message in the console.
(In reply to comment #7)
> Contacted the WG:
> http://lists.w3.org/Archives/Member/w3c-forms/2005JulSep/0106.html

Has just been resolved. We should dispatch an xforms-submit-error.
Attached patch PatchSplinter Review
Created EndSubmit() which enables the activator, and dispatches the event. This
is then called if do data is available.
Attachment #197396 - Flags: review?(doronr)
Attachment #197396 - Flags: review?(doronr) → review+
Attachment #197396 - Flags: review?(smaug)
Attachment #197396 - Flags: review?(smaug) → review+
Checked in to trunk
Status: NEW → ASSIGNED
Whiteboard: xf-to-branch
checked into branch 20051004
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
Keywords: fixed1.8
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.