292865 - Throbber/"Loading" doesn't appear when tab bar gets displayed

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dave Wickham]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050503 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050503 Firefox/1.0+

When Firefox is started up with the tab bar hidden, a page is loaded in this
tab, then a new tab is opened whilst the page is downloading, the throbber isn't
shown on the original tab, nor is the "Loading" status shown; instead it shows
the title of the previous page, along with the favicon (if applicable). It
appears that it's similar to bug #233266 , but different.

Reproducible: Always

Steps to Reproduce:
1. Open a new Firefox window, with the tab bar disabled.
2. Load any page.
3. Load something which takes a while to load (example: http://icculus.org/lgfaq/ ).
4. Whilst that's loading, open a new tab, bringing up the tab bar.
Actual Results:  
The original page doesn't reflect the loading process, both in the
"mini-throbber" and in the tab name.

Expected Results:  
The tab should reflect the fact that it is loading.

Same problem with the current Ubuntu Breezy package as well as the latest
nightly. Not tested on seamonkey.

Comment 1

[Andrew Schultz]

confirmed with current firefox CVS

bug 297155 exists for the same bug in the suite

Comment 2

[Takeshi Nishimura]

You can also test this bug by:
1. Open a new window.
2. Right-click on a bookmark folder (e.g. "Firefox and Mozilla Links") and
select "Open in Tabs".
3. See the left-most tab.

Furthermore, this bug causes the throbber in the toolbar to spin forever.
1. Create a bookmark folder containing two bookmarks like following:
	TESTFOLDER
	 + any URL
	 + about:blank
2. Open a new window.
3. Right-click on the bookmark folder and select "Open in Tabs".
4. While loading, switch to the right tab.
5. Look at the throbber in the toolbar.
In latter case "mini-throbber"s in tabs works correctly.

Comment 3

[Takeshi Nishimura]

Attachment: Quick fix

This does also fix following bugs around tabs.
- Firefox sometime shows "Lo....." instead of "Loa..." in tabs when cropped. 
  (I.e. the cropping position of "Loading..." is not determinate.)

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch for check-in

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.

Comment 6

[Bradley Chapman (not reading bugmail, still gone but not forever)]

Is attachment 196217 [details] [diff] [review] safe for the 1.8 branch? Or is it far too late to take this
sort of change?

Comment 7

[Takeshi Nishimura]

> Is attachment 196217 [details] [diff] [review] safe for the 1.8 branch?

Yes, I think, though I can't respond to the latter question.
I'll do more test if this bug cound be fixed in branch.

(irrelevant dependency cleared)

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch for checked-in to 1.8 branch