292878 - Support OS X 10.4 (Tiger) .webloc file format

Status: RESOLVED FIXED

(Camino Graveyard :: OS Integration, defect)

Description

[Bruce Davidson]

OS X 10.4 (Tiger) [apparently] uses a different format of webloc files from
previous releases of OS X 10.3. Previous releases used the resource fork to
store the URL, and the title was just the filename (minus its extension).

The new format is a plist file.

(Note the developers: the code for reading webloc files is currently being moved
around in bug 155484, but won't be solved there, because neither wevah or I yet
have Tiger)

Comment 1

[Wevah (Nate Weaver)]

Me!

Comment 2

[Wevah (Nate Weaver)]

Hmm...it looks like Tiger saves the old-style resource-based info in the file as
well. The current code reads it fine.

Comment 3

[Wevah (Nate Weaver)]

On second thought, people might accidentally kill the resource fork, so we
should check for the plist if the resource isn't found. (And it looks like even
10.2 can open plist-style .inetlocs). I'll submit a patch once the NSURL+Utils.*
are checked in.

Comment 4

[Josh Aas]

As our code apparently works as it, this should not be an 0.9 blocker. Would be
nice to have though.

Comment 5

[Samuel Sidler (old account; do not CC)]

Wevah, any progress? Or are you still waiting for the NSURL+Utils.*?

Comment 6

[Samuel Sidler (old account; do not CC)]

I think this should block simply because we should support Tiger well enough to support it's weblocs.

Wevah, can you pop out a quick fix for this?

Comment 7

[Wevah (Nate Weaver)]

We *do* support Tiger's weblocs. Tiger still saves the resource fork data (last I checked), but it also uses a plist in the data fork.

That said, yes I can.

Comment 8

[Wevah (Nate Weaver)]

Attachment: Patch that adds plist reading.

This adds reading of the plist-style internet location data, if the file has no resource fork or lacks the appropriate 'url ' resource.

Comment 9

[Simon Fraser [no longer active]]

Comment on attachment 204971 [details] [diff] [review]
Patch that adds plist reading.

r=me but kill the tabs, please.

Comment 10

[Wevah (Nate Weaver)]

Oops; I made sure to have my tab settings set up properly, and then I went and copied from a tabbed source file without replacing.

Comment 11

[Wevah (Nate Weaver)]

Attachment: Patch without tabs.

Comment 12

[Simon Fraser [no longer active]]

Fixed everywhere.

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Clearing ? request on fixed bug; apologies for bugspam.