292886 - X-Bugzilla-Product and X-Bugzilla-Component headers should exist by default

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, enhancement)

Description

[Max Kanat-Alexander]

My new mozbot-receives-bugmail-and-reports-it-to-IRC code depends on the
X-Bugzilla-Product and X-Bugzilla-Component headers. I noticed that my bot
wasn't reporting flag changes, and when I investigated, I discovered that at
least from b.m.o, the X-Bugzilla-Product and X-Bugzilla-Component headers aren't
being set in flag mail, at least from bug flags.

Comment 1

[Max Kanat-Alexander]

I'd really like to get this fix into 2.18, or my mozbot code will be pretty useless.

Comment 2

[Max Kanat-Alexander]

OK, I should be more specific -- the headers are actually missing from my
*bugmail*, not the "request" mail.

Comment 3

[Max Kanat-Alexander]

Arrgh, the actual problem is that Bugzillas don't contain these headers by
default. Adding them by default wouldn't be too hard.

Comment 4

[Albert Ting]

Isn't this bug #70710?

Comment 5

[Max Kanat-Alexander]

(In reply to comment #4)
> Isn't this bug #70710?

  No -- we already have %component% and %product%, they're just not being used
by default.

Comment 6

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 7

[Frédéric Buclin]

Comment on attachment 192338 [details] [diff] [review]
Patch

This makes perfect sense to me. At least, it's easier to remove them if we
don't want them.
r=LpSolit for 2.20 and tip only.

Comment 8

[Frédéric Buclin]

tip:

Checking in defparams.pl;
/cvsroot/mozilla/webtools/bugzilla/defparams.pl,v  <--  defparams.pl
new revision: 1.166; previous revision: 1.165
done

2.20rc2:

Checking in defparams.pl;
/cvsroot/mozilla/webtools/bugzilla/defparams.pl,v  <--  defparams.pl
new revision: 1.160.2.2; previous revision: 1.160.2.1
done