292893 - toolkit/themes/Makefile.in uses qute for all-but-phoenix

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Axel Hecht]

The logic in toolkit/thems/Makefile.in is reversed. It uses winstripe for 
winstripe for phoenix and qute for everything else. The logic is to use
qute for thunderbird and winstripe for everything else.
This breaks help viewer in xulrunner, at least.

Patch coming up.

Comment 1

[Axel Hecht]

Attachment: use ifndef MOZ_THUNDERBIRD instead

Comment 2

[Darin Fisher]

I was just about to file this bug too! ;-)

Comment 3

[Benjamin Smedberg]

Comment on attachment 182609 [details] [diff] [review]
use ifndef MOZ_THUNDERBIRD instead

r=me... this doesn't change tbird, so I don't think mscott need worry. Sunbird
might be different, though.

Comment 4

[Axel Hecht]

requesting sunbird input on this change ...

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

I always assumed that the default was winstripe. I guess this is the right
change to make, but i didn't test it yet. (But did i mention that any #ifdef
MOZ_APPNAME in toolkit is just plain wrong?)

Comment 6

[Darin Fisher]

#ifdef's in toolkit are definitely wrong, but the goal is to get rid of them
gradually.  if possible we are trying to only have ifdefs for thunderbird since
removing ifdefs for thunderbird is going to be the most challenging it seems.

Comment 7

[Scott MacGregor]

(In reply to comment #6)
> #ifdef's in toolkit are definitely wrong, but the goal is to get rid of them
> gradually.  if possible we are trying to only have ifdefs for thunderbird since
> removing ifdefs for thunderbird is going to be the most challenging it seems.  

Are you saying we should move theme code out of toolkit to avoid this ifdef?
There's no requirement that says everyone of our applications is going to use
winstripe or qute or something else. 

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

afaik, the idea is that toolkit can be shared between apps. If an app wants it's
own theme, it can override the toolkit theme.
But i didn't wanted to start this discussion here, I was just a bit bitter about
another ifdef that means more work for sunbird.

Comment 9

[Benjamin Smedberg]

The toolkit/xulrunner is going to ship with one theme, called "classic". This is
winstripe/pinstripe/qtstripe/whatever depending on platform. The difference
between qute and winstripe is minimal in the toolkit code: the real differences
are all in the icons and such, which are all app-specific.

It is reasonable in the future for tbird to use the "winstripe" theme for the
toolkit bits, and continue to use the Qute icons and app-specific style rules.
Of course they are going to be packaged in different JAR files anyway.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 182609 [details] [diff] [review]
use ifndef MOZ_THUNDERBIRD instead

a=asa

Comment 11

[Axel Hecht]

Checked in. I filed bug 292995 for more #ifdef MOZ_PHOENIX goodness in qute.
(Which actually triggered the filing of this bug, to be honest.)