Closed Bug 292913 Opened 20 years ago Closed 19 years ago

Potential OOM crash [@ LoadDirsIntoArray]

Categories

(Toolkit :: Startup and Profile System, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: bastiaan)

References

()

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

> RCS file: /cvsroot/mozilla/toolkit/xre/nsXREDirProvider.cpp,v
> +      nsCOMPtr<nsILocalFile>
> dir(do_CreateInstance("@mozilla.org/file/local;1"));
> +      rv = dir->SetPersistentDescriptor(nsDependentCString(parserBuf));

can we please not crash when alloc fails?
Attached patch fixSplinter Review
Assignee: nobody → b.jacques
Status: NEW → ASSIGNED
Comment on attachment 187716 [details] [diff] [review]
fix

r=darin
Attachment #187716 - Flags: first-review+
Attachment #187716 - Flags: approval1.8b3?
Attachment #187716 - Flags: approval-aviary1.1a2?
Comment on attachment 187716 [details] [diff] [review]
fix

a=bsmedberg for checkin on 6/30 only
Attachment #187716 - Flags: approval1.8b3?
Attachment #187716 - Flags: approval1.8b3+
Attachment #187716 - Flags: approval-aviary1.1a2?
It looks like timeless checked this in.  Marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Component: XRE Startup → Startup and Profile System
QA Contact: nobody → startup
Crash Signature: [@ LoadDirsIntoArray]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: