292915 - Invalid controls not initialized as invalid

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

We've regressed something somewhere.  We aren't running through node validation
anymore during form load.  We still call nsXFormsMDGEngine::Revalidate, but
mChangedNodes in nsXFormsModelElement::Revalidate is empty.  The result is that
if we initialize a field with a value from an invalid type, the control is not
marked invalid.

Comment 1

[aaronr]

Attachment: testcase

This testcase initializes the input field with the character "a" but the type
on the bind is "xsd:integer".  I put style in the testcase so that the input
should turn red if invalid.

Comment 2

[Allan Beaufour]

It has been a while since that has worked I think. The problem comes from bug
284101 I think.

The problem is that validation is never triggered if type information is the
only MIP on the instance node.

Comment 3

[Allan Beaufour]

Attachment: Patch

This patch triggers type validation after a rebuild.

(it also does adds null check but it's debug-only)

Comment 4

[aaronr]

Comment on attachment 183155 [details] [diff] [review]
Patch

dandy!

Comment 5

[Allan Beaufour]

Checked in.