292934 - Favicon not updated when going back/forward in tab with bfcache/fastback

Status: RESOLVED WORKSFORME

(Core :: DOM: Navigation, defect)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050504
Firefox/1.0+ after landing of bug 274784
browser.sessionhistory.max_viewers 20

1. New Profile, open firefox.
2. Open "Getting Started" bookmark into a new tab (middle click). Note the
firefox favicon.
3. Go to www.neowin.net in the same tab. Note the neowin favicon
4. Click back. Note that the neowin favicon is now shown on the page that should
display the firefox favicon.

Comment 1

[[e-mail]]

I assume we need some way of saving the last validated icon into bfcache?
Hopefully this will allow us to move some icon handling out of tabbrowser,
thus fixing a couple of the other favicon bugs out there ;-)

Comment 2

[José Jeria]

*** Bug 293119 has been marked as a duplicate of this bug. ***

Comment 3

[Kevin Brosnan]

*** Bug 294776 has been marked as a duplicate of this bug. ***

Comment 4

[John Center]

I'm seeing something similar.  I was viewing a blog, entered a search item in
the search bar, went to Google, then selected a search item to view.  I then
went back to the blog page I was viewing.  The icon in the tab was now the icon
of the search item page.  It hasn't changed in the bookmarks, only on the tab. 
I have the bfcache enabled.

Comment 5

[Max]

*** Bug 295825 has been marked as a duplicate of this bug. ***

Comment 6

[Aaron Slunt]

Can bug owner, or someone with privs, set OS->ALL

And I hope this blocks 1.1: this bug is too noticeable to go in a 1.1 release.

Comment 7

[mark]

why not to add gBrowser.loadFavIcon(gBrowser.currentURI, "image",
gBrowser.selectedTab);

to BrowserBack and BrowserForward functions 

Comment 8

[Jaime Mitchell (use [e-mail] for email)]

*** Bug 297205 has been marked as a duplicate of this bug. ***

Comment 9

[Derek Poon]

The Live Bookmarks icon also suffers from the problem (Bug 297205).  Therefore, the fix should involve a 
proper notification mechanism, rather than the kludge suggested in Comment 7.

<speculation>There might be other parts of the browser that are similarly out of sync, possibly opening 
the way towards a phishing exploit.</speculation>

Comment 10

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050616
Firefox/1.0+ ID:2005061606
Since (i think) the landing of bug 292971, this bug now appears to WFM. The
tabbar's site favicon now matches the site it is showing, even with bfcache enabled.

Comment 11

[Ben Basson]

Haven't tested Live Bookmarks but also WFM...

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050616
Firefox/1.0+

Comment 12

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050616
Firefox/1.0+ ID:2005061607

WFM

Comment 13

[Benoît]

Not sure if I should open a new bug on this.

The favicon's behavior is still not consistent. Half of the time, when you click
on a link, you see the favicon rapidly switching between the site's and the
bookmark's once, while loading. Also, if you open a new tab, and then close it,
the favicon isn't updated, and falls back to the bookmark's icon.