Closed Bug 292934 Opened 15 years ago Closed 15 years ago

Favicon not updated when going back/forward in tab with bfcache/fastback

Categories

(Core :: Document Navigation, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: stevee, Unassigned)

References

Details

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050504
Firefox/1.0+ after landing of bug 274784
browser.sessionhistory.max_viewers 20

1. New Profile, open firefox.
2. Open "Getting Started" bookmark into a new tab (middle click). Note the
firefox favicon.
3. Go to www.neowin.net in the same tab. Note the neowin favicon
4. Click back. Note that the neowin favicon is now shown on the page that should
display the firefox favicon.
No longer depends on: blazinglyfastback
I assume we need some way of saving the last validated icon into bfcache?
Hopefully this will allow us to move some icon handling out of tabbrowser,
thus fixing a couple of the other favicon bugs out there ;-)
*** Bug 293119 has been marked as a duplicate of this bug. ***
*** Bug 294776 has been marked as a duplicate of this bug. ***
I'm seeing something similar.  I was viewing a blog, entered a search item in
the search bar, went to Google, then selected a search item to view.  I then
went back to the blog page I was viewing.  The icon in the tab was now the icon
of the search item page.  It hasn't changed in the bookmarks, only on the tab. 
I have the bfcache enabled.
*** Bug 295825 has been marked as a duplicate of this bug. ***
Flags: blocking-aviary1.1?
Can bug owner, or someone with privs, set OS->ALL

And I hope this blocks 1.1: this bug is too noticeable to go in a 1.1 release.
OS: Windows 2000 → All
why not to add gBrowser.loadFavIcon(gBrowser.currentURI, "image",
gBrowser.selectedTab);

to BrowserBack and BrowserForward functions 
*** Bug 297205 has been marked as a duplicate of this bug. ***
The Live Bookmarks icon also suffers from the problem (Bug 297205).  Therefore, the fix should involve a 
proper notification mechanism, rather than the kludge suggested in Comment 7.

<speculation>There might be other parts of the browser that are similarly out of sync, possibly opening 
the way towards a phishing exploit.</speculation>
Summary: Favicon not updated when going back/forward in tab → Favicon not updated when going back/forward in tab with bfcache/fastback
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050616
Firefox/1.0+ ID:2005061606
Since (i think) the landing of bug 292971, this bug now appears to WFM. The
tabbar's site favicon now matches the site it is showing, even with bfcache enabled.
Haven't tested Live Bookmarks but also WFM...

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050616
Firefox/1.0+
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050616
Firefox/1.0+ ID:2005061607

WFM
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WORKSFORME
Flags: blocking-aviary1.1?
Not sure if I should open a new bug on this.

The favicon's behavior is still not consistent. Half of the time, when you click
on a link, you see the favicon rapidly switching between the site's and the
bookmark's once, while loading. Also, if you open a new tab, and then close it,
the favicon isn't updated, and falls back to the bookmark's icon.
Component: History: Session → Document Navigation
QA Contact: history.session → docshell
You need to log in before you can comment on or make changes to this bug.