Favicon not updated when going back/forward in tab with bfcache/fastback

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
14 years ago
11 years ago

People

(Reporter: stevee, Unassigned)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

14 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050504
Firefox/1.0+ after landing of bug 274784
browser.sessionhistory.max_viewers 20

1. New Profile, open firefox.
2. Open "Getting Started" bookmark into a new tab (middle click). Note the
firefox favicon.
3. Go to www.neowin.net in the same tab. Note the neowin favicon
4. Click back. Note that the neowin favicon is now shown on the page that should
display the firefox favicon.
No longer depends on: 274784
(Reporter)

Updated

14 years ago
Blocks: 274784
I assume we need some way of saving the last validated icon into bfcache?
Hopefully this will allow us to move some icon handling out of tabbrowser,
thus fixing a couple of the other favicon bugs out there ;-)

Comment 2

14 years ago
*** Bug 293119 has been marked as a duplicate of this bug. ***

Comment 3

14 years ago
*** Bug 294776 has been marked as a duplicate of this bug. ***

Comment 4

14 years ago
I'm seeing something similar.  I was viewing a blog, entered a search item in
the search bar, went to Google, then selected a search item to view.  I then
went back to the blog page I was viewing.  The icon in the tab was now the icon
of the search item page.  It hasn't changed in the bookmarks, only on the tab. 
I have the bfcache enabled.

Comment 5

14 years ago
*** Bug 295825 has been marked as a duplicate of this bug. ***

Updated

14 years ago
Flags: blocking-aviary1.1?

Comment 6

14 years ago
Can bug owner, or someone with privs, set OS->ALL

And I hope this blocks 1.1: this bug is too noticeable to go in a 1.1 release.

Updated

14 years ago
OS: Windows 2000 → All

Comment 7

14 years ago
why not to add gBrowser.loadFavIcon(gBrowser.currentURI, "image",
gBrowser.selectedTab);

to BrowserBack and BrowserForward functions 
*** Bug 297205 has been marked as a duplicate of this bug. ***

Comment 9

14 years ago
The Live Bookmarks icon also suffers from the problem (Bug 297205).  Therefore, the fix should involve a 
proper notification mechanism, rather than the kludge suggested in Comment 7.

<speculation>There might be other parts of the browser that are similarly out of sync, possibly opening 
the way towards a phishing exploit.</speculation>
Summary: Favicon not updated when going back/forward in tab → Favicon not updated when going back/forward in tab with bfcache/fastback
(Reporter)

Comment 10

14 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050616
Firefox/1.0+ ID:2005061606
Since (i think) the landing of bug 292971, this bug now appears to WFM. The
tabbar's site favicon now matches the site it is showing, even with bfcache enabled.

Comment 11

14 years ago
Haven't tested Live Bookmarks but also WFM...

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050616
Firefox/1.0+
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050616
Firefox/1.0+ ID:2005061607

WFM
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → WORKSFORME

Updated

14 years ago
Flags: blocking-aviary1.1?

Comment 13

14 years ago
Not sure if I should open a new bug on this.

The favicon's behavior is still not consistent. Half of the time, when you click
on a link, you see the favicon rapidly switching between the site's and the
bookmark's once, while loading. Also, if you open a new tab, and then close it,
the favicon isn't updated, and falls back to the bookmark's icon.

Updated

11 years ago
Component: History: Session → Document Navigation
QA Contact: history.session → docshell
You need to log in before you can comment on or make changes to this bug.