Closed Bug 292947 Opened 19 years ago Closed 19 years ago

Password manager needs to check isTrusted on DOMPageRestore events

Categories

(Toolkit :: Password Manager, defect)

Product:
Toolkit
Component:
Password Manager
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bzbarsky, Unassigned)

References

Details

This is a review comment from bug 274784:

  Also, what happens if content fires DOMPageRestore events?  Wouldn't autofill
  trigger on those?  Do we need some isTrusted checks here?
Blocks: blazinglyfastback
This was actually addressed in the last patch I posted:

NS_IMETHODIMP
nsPasswordManager::PageRestore(nsIDOMEvent* aEvent)
{
  // Only autofill for trusted events.
  nsCOMPtr<nsIDOMNSEvent> nsevent = do_QueryInterface(aEvent);
  PRBool trusted = PR_FALSE;
  if (nsevent)
    nsevent->GetIsTrusted(&trusted);
  if (!trusted)
    return NS_OK;
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.