save as folder for search results for news offers news server but not in dropdown

NEW
Unassigned

Status

SeaMonkey
MailNews: Message Display
--
minor
13 years ago
9 years ago

People

(Reporter: timeless, Unassigned)

Tracking

Trunk
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: INB)

Attachments

(1 attachment)

1.08 KB, patch
Karsten Düsterloh
: review-
Details | Diff | Splinter Review
(Reporter)

Description

13 years ago
steps:
1. create a news account (news.mozilla.org)
2. subscribe to a newsgroup (...)
3. search for subject contains ' '
4. click save as search folder

Actual results:
> Create as a subfolder of: [news.mozilla.org      |v]
>                           |Local Folders       >   |
>                           |________________________|

the default is news.mozilla.org (the news server), but it isn't available in the
drop down (and afaik it doesn't work either).

Comment 1

13 years ago
Confirming
Assignee: mail → bugzilla
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

13 years ago
Status: NEW → ASSIGNED

Comment 2

13 years ago
Created attachment 182901 [details] [diff] [review]
Patch v0.1

This patch:
* Adds a check to see if the server for the preselected URI can create
subfolders.

Saying that you can save searches to a newsgroup account as they are only
virtual folders, so perhaps the fix here should be to include newsgroups
accounts as possible places to save the search too.
Attachment #182901 - Flags: review?(mnyromyr)

Comment 3

13 years ago
Comment on attachment 182901 [details] [diff] [review]
Patch v0.1

>+  if (gCurrentFolder.server.canCreateFoldersOnServer)
>+    preselectedURI = gCurrentFolder.URI;
> 
>+  var searchFolderURIs = gCurrentFolder.URI;
>   var searchSubfolders = document.getElementById("checkSearchSubFolders").checked;
>   if (gCurrentFolder && (searchSubfolders || gCurrentFolder.isServer || gCurrentFolder.noSelect))

All other users of gCurrentFolder assume it does exist, so the check in the
last line, too, isn't needed.

r=me with that.
Attachment #182901 - Flags: review?(mnyromyr) → review+

Comment 4

13 years ago
BTW: Which server types do actually exist where we *cannot* save such a virtual
folder? 

Comment 5

13 years ago
I've tested on news and IMAP and it works for both of them, I could test for POP
and RSS but not had chance to yet.

Comment 6

13 years ago
So while this patch fixes the immediate inconsistency, the real "problem" most
probably is MsgFolderPickerOnLoad(...), because it doesn't know about the places
where virtual folders can be created - and canCreateFoldersOnServer is obviously
the wrong question to ask...
I think we should at least explore the "bigger" solution before going on with
the current one.

Comment 7

13 years ago
Comment on attachment 182901 [details] [diff] [review]
Patch v0.1

Uh, just found a problem: if |preselectedURI = null| and the search messages
dialog is opened from a news server, the first/default account is selected. But
you can't click okay before you did explicitly select an entry from the
dropdown!
Sorry for this late find. :( 
(setting r-)
Attachment #182901 - Flags: review+ → review-
Ian,
Are you still working on this ?

Comment 9

10 years ago
Not at the moment, but I don't want to lose track of it
Assignee: iann_bugzilla → mail
Status: ASSIGNED → NEW
QA Contact: search
Whiteboard: INB
(Reporter)

Updated

9 years ago
Component: MailNews: Search → MailNews: Message Display
Assignee: mail → nobody
QA Contact: search → message-display
You need to log in before you can comment on or make changes to this bug.