steps: 1. create a news account (news.mozilla.org) 2. subscribe to a newsgroup (...) 3. search for subject contains ' ' 4. click save as search folder Actual results: > Create as a subfolder of: [news.mozilla.org |v] > |Local Folders > | > |________________________| the default is news.mozilla.org (the news server), but it isn't available in the drop down (and afaik it doesn't work either).
Created attachment 182901 [details] [diff] [review] Patch v0.1 This patch: * Adds a check to see if the server for the preselected URI can create subfolders. Saying that you can save searches to a newsgroup account as they are only virtual folders, so perhaps the fix here should be to include newsgroups accounts as possible places to save the search too.
Comment on attachment 182901 [details] [diff] [review] Patch v0.1 >+ if (gCurrentFolder.server.canCreateFoldersOnServer) >+ preselectedURI = gCurrentFolder.URI; > >+ var searchFolderURIs = gCurrentFolder.URI; > var searchSubfolders = document.getElementById("checkSearchSubFolders").checked; > if (gCurrentFolder && (searchSubfolders || gCurrentFolder.isServer || gCurrentFolder.noSelect)) All other users of gCurrentFolder assume it does exist, so the check in the last line, too, isn't needed. r=me with that.
BTW: Which server types do actually exist where we *cannot* save such a virtual folder?
I've tested on news and IMAP and it works for both of them, I could test for POP and RSS but not had chance to yet.
So while this patch fixes the immediate inconsistency, the real "problem" most probably is MsgFolderPickerOnLoad(...), because it doesn't know about the places where virtual folders can be created - and canCreateFoldersOnServer is obviously the wrong question to ask... I think we should at least explore the "bigger" solution before going on with the current one.
Comment on attachment 182901 [details] [diff] [review] Patch v0.1 Uh, just found a problem: if |preselectedURI = null| and the search messages dialog is opened from a news server, the first/default account is selected. But you can't click okay before you did explicitly select an entry from the dropdown! Sorry for this late find. :( (setting r-)
Ian, Are you still working on this ?
Not at the moment, but I don't want to lose track of it