293089 - Context menu for saved search folder doesn't include delete search

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[timeless]

steps:
1. create a news account (news.mozilla.org)
2. subscribe to netscape
3. search for summary contains ' ' in netscape
4. save as search folder "local folders\test"
5. right click "test"

actual results (context menu):
Open in New Mail Window
Copy Folder Location
-
Mark Folder Read
Compact This Folder
-
Search Messages ... (disabled)
Properties

what's missing?
delete.

Comment 1

[Ian Neal]

This was fixed on TB on bug 270643

Comment 2

[Ian Neal]

Attachment: Patch v0.1 (Checked in)

This patch:
* Gives "Delete" and "Rename" context menuitems for saved searches (as per TB
bug fix)

Comment 3

[Karsten Düsterloh]

Comment on attachment 182948 [details] [diff] [review]
Patch v0.1 (Checked in)

After renaming a virtual folder, I'm getting an exception dumped:
|failed to get view & sort values.  ex = TypeError: gSearchInput has no
properties|
(->
http://lxr.mozilla.org/mozilla/source/mailnews/base/resources/content/commandgl
ue.js#912).

This patch does not change anything if the virtual folder's parent server is a
news server - unsubscribe is still available as a kind of delete. -> JFTR: a
related issue is part of bug 293086.

Comment 4

[Karsten Düsterloh]

Comment on attachment 182948 [details] [diff] [review]
Patch v0.1 (Checked in)

FWIW: after some testing I found out that all my testing profiles must have
been broken somehow and result in the (caught) exception mentioned in comment 3
- but likely is that? :-/
Anyway, with a clean profile a can't reproduce anymore... (But I'll keep an eye
on that!)

Comment 5

[[e-mail]]

Comment on attachment 182948 [details] [diff] [review]
Patch v0.1 (Checked in)

Heh, you can't delete a saved search from an IMAP account if you're offline!

Comment 6

[Ian Neal]

Comment on attachment 182948 [details] [diff] [review]
Patch v0.1 (Checked in)

Requesting a= for fairly low risk suite-only patch

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 182948 [details] [diff] [review]
Patch v0.1 (Checked in)

a=asa

Comment 8

[Ian Neal]

Comment on attachment 182948 [details] [diff] [review]
Patch v0.1 (Checked in)

Checking in mailContextMenus.js;
new revision: 1.54; previous revision: 1.53
done

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; it's called Delete Folder.

Build: 2006-01-04-09 of SeaMonkey trunk on Windows XP.