Closed Bug 293124 Opened 19 years ago Closed 19 years ago

useless initialization after memset in CMozillaBrowser::OnSaveAs

Categories

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

x86
Windows XP
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timeless, Assigned: mcsmurf)

References

()

Details

Attachments

(1 obsolete file)

memset makes the entire structure null, why bother nulling out individual items
afterward?
Attached patch Patch (obsolete) — Splinter Review
Attachment #182793 - Flags: review?(timeless)
Attachment #182793 - Flags: superreview?(tor)
Attachment #182793 - Flags: review?(timeless)
Attachment #182793 - Flags: review+
Attachment #182793 - Flags: superreview?(tor) → superreview+
Attachment #182793 - Flags: approval1.8b3?
Comment on attachment 182793 [details] [diff] [review]
Patch

a=shaver
Attachment #182793 - Flags: approval1.8b3? → approval1.8b3+
Assignee: adamlock → bugzilla
fixed.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 182793 [details] [diff] [review]
Patch

mozilla/embedding/browser/activex/src/control/MozillaBrowser.cpp	1.112
Attachment #182793 - Attachment is obsolete: true
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: