293150 - showAlertNotification method of nsIAlertsService interface can make Mozilla apps. crash

Status: RESOLVED WORKSFORME

(Toolkit Graveyard :: XULRunner, defect)

Description

[Serlio]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.7) Gecko/20050414 Firefox
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.7) Gecko/20050414 Firefox

Firstly, sorry if this is not the adequate Component for this bug. I've searched
showAlertNotification in Bugzilla and I haven't found any bug. I've read several
components description but I'm not familiarized with Mozilla terminology, so
it's difficult for me to find the best fitting component for this bug.

And now, the bug: Some parameters passed to showAlertNotification method of
nsIAlertsService interface are not validated, so null pointers will make the
application crash. This can happen for example with a faulty extension for
Firefox or Thunderbird.

Reproducible: Always

Steps to Reproduce:
1.Open the Javascript console (for example, in Firefox or Thunderbird).

2.Enter the following line:
var gQm_Alerts =
Components.classes["@mozilla.org/alerts-service;1"].getService(Components.interfaces.nsIAlertsService);
gQm_Alerts.showAlertNotification(null, null, null, false, "", null);

3. Evaluate it

Actual Results:  
The application crashes.

Expected Results:  
Raise a javascript error, I think.

Comment 1

[timeless]

wfm w/ seamonkey (4/19-05), given that this code is forked you might need to
move your bug to toolkit.

tested:
in javascript console:
Components.classes["@mozilla.org/alerts-service;1"].getService(Components.interfaces.nsIAlertsService).showAlertNotification(null,
null, null, false, "", null);

Comment 2

[Serlio]

mmmm... I guess you are refering to XP Toolkit. But in my understanding, XP
means "Cross-platform", and if I'm not wrong the nsIAlertsService interface is
only implemented for Windows systems. Is it important? Sorry, this is my first
bug and I'm not a Mozilla expert, only an extensions developer.

Comment 3

[timeless]

no, i'm refering to product "Toolkit" this bug is currently in product "Core".

Comment 4

[Serlio]

OK, moved to Toolkit. And XULRunner, I guess. Thank you.

Comment 5

[Nickolay_Ponomarev]

WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050819
Firefox/1.0+

Could you retest with a Deer Park build, please?

Comment 6

[Serlio]

It does not crash in Firefox 1.5 Beta 1
(tested according to comment #1)

Comment 7

[Nickolay_Ponomarev]

resolving