Closed Bug 293198 Opened 19 years ago Closed 19 years ago

Help Viewer sidebar has lost its styling

Categories

(SeaMonkey :: Help Documentation, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: iannbugzilla, Assigned: WeirdAl)

References

(Depends on 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Since the landing of bug 178003 the sidebar in help viewer no longer has any
styling.
It used to pulled in sidebar.css via navigator.css, Neil suggests that help.css
should be used to import sidebar.css now.
I'm happy to review the patch ;-)
Assignee: neil.parkwaycc.co.uk → ajvincent
Status: NEW → ASSIGNED
Attachment #182835 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #182835 - Flags: review?(bugzilla)
Attachment #182835 - Flags: review?(bugzilla) → review+
Comment on attachment 182835 [details] [diff] [review]
patch -- add skin/sidebar.css to skin/help.css

CSS Error (chrome://communicator/skin/help.css :40.8) Unrecognized at-rule or
error parsing at-rule '@import'.

Try putting the @import before the @namespace?
Moving over the r+ from the previous patch.
Attachment #182835 - Attachment is obsolete: true
Attachment #183004 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #183004 - Flags: review+
Attachment #182835 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #183004 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Comment on attachment 183004 [details] [diff] [review]
place the @import rule before the @namespace rule (Checked in)

This bug was filed as a regression to bug 178003, which had approval1.8b2+. 
Requesting approval.
Attachment #183004 - Flags: approval1.8b2?
Comment on attachment 183004 [details] [diff] [review]
place the @import rule before the @namespace rule (Checked in)

a=shaver for regression prevention.
Attachment #183004 - Flags: approval1.8b2? → approval1.8b2+
Comment on attachment 183004 [details] [diff] [review]
place the @import rule before the @namespace rule (Checked in)

Checking in classic/help.css;
new revision: 1.16; previous revision: 1.15
Checking in modern/help.css;
new revision: 1.15; previous revision: 1.14
done
Attachment #183004 - Attachment description: place the @import rule before the @namespace rule → place the @import rule before the @namespace rule (Checked in)
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Verified FIXED in build 2006-01-04-09 of trunk SeaMonkey under Windows XP.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: