Closed Bug 293225 Opened 15 years ago Closed 15 years ago

Default height of CANVAS should be 150

Categories

(Core :: Canvas: 2D, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: annevk, Assigned: annevk)

References

Details

Attachments

(1 obsolete file)

I believe this recently changed from 200, but I guess Hixie had his reasons.
 <http://whatwg.org/specs/web-apps/current-work/#canvas>

See also bug 291216 comment 39. Patch coming up.
Attached patch change 200 to 150 (obsolete) — Splinter Review
Assignee: nobody → bug
Status: NEW → ASSIGNED
Attachment #182848 - Flags: superreview?(bzbarsky)
Attachment #182848 - Flags: review?(vladimir)
Attachment #182848 - Flags: approval1.8b2?
The reasoning was that these numbers should match the <iframe> default size.
Please check that they are the right numbers to do this when checking in.
<iframe src="data:text/plain,PASS">FAIL</iframe>
<script>alert(window.getComputedStyle(document.getElementsByTagName('iframe')[0],null).height);</script>

... returns 150px for me. And when replacing 'height' with 'width' I get 300px
so that seems to be ok.
Comment on attachment 182848 [details] [diff] [review]
change 200 to 150

please don't request approval until you've got sufficient reviews. thanks.
Attachment #182848 - Flags: approval1.8b2?
"What Does Apple Do?"
They require height/width and have no error handling behaviour if they are missing.
I rolled this patch into the patch in bug 293407.
Depends on: 293407
Checked in as part of bug 293407.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #182848 - Attachment is obsolete: true
Attachment #182848 - Flags: superreview?(bzbarsky)
Attachment #182848 - Flags: review?(vladimir)
You need to log in before you can comment on or make changes to this bug.