Closed Bug 293255 Opened 16 years ago Closed 15 years ago

Add Reviewer contact information to the outgoing mails.

Categories

(addons.mozilla.org Graveyard :: Developer Pages, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jdittmer, Assigned: Bugzilla-alanjstrBugs)

Details

(Whiteboard: [landme])

Attachments

(1 file, 3 obsolete files)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.7) Gecko/20050421 Firefox/1.0.3 (Debian package 1.0.3-2)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.7) Gecko/20050421 Firefox/1.0.3 (Debian package 1.0.3-2)

Currently the mails are quite crude:
--
Your item was tested by the editor using FF1.0.3 on Debian/Linux.
Editor's Comments:
--
It'd be nice to get the reviewers name and possibly email (or mailing list) in
there.

Reproducible: Always
Confirming. Would be nice to have, especially when the reviewer makes some
suggestions you want to reply to or he denies the approval and you want to
"defend" yourself :-)

To keep things fair, reviewers should perhaps get a checkbox on the review page
to stay anonymous.
Status: UNCONFIRMED → NEW
Ever confirmed: true
I wouldn't mind it adding my name, but I don't want my email address going out.

Status: NEW → ASSIGNED
OS: Linux → All
Hardware: PC → All
Target Milestone: 1.0 → 1.1
I haven't been receiving my test denial email, so I'm not sure if this is
readyy for review yet.
$_SESSION['name'] is defined in login when people log in, why not use that
rather than do another SQL query?
good point.  
Attached patch session's user (obsolete) — Splinter Review
Also wrapped the comments block in an if for when the reviewer doesn't add a
comment.
Attachment #186044 - Attachment is obsolete: true
Attachment #186058 - Flags: first-review?(colin.ogilvie)
Comment on attachment 186058 [details] [diff] [review]
session's user

>Index: public_html/developers/mail_approval.php
>+    $message .= "Your item was tested by $_SESSION[name] using $testbuild on $testos.\n";
>+    if ($comments != "") {
>+      $message .= "Editor's Comments:\n $comments\n";
>+    }

$_SESSION['name'] - please include the single quotes around the key of the
array.
Attachment #186058 - Flags: first-review?(colin.ogilvie) → first-review-
Attached patch Quoted (obsolete) — Splinter Review
Attachment #186058 - Attachment is obsolete: true
Attachment #186173 - Flags: first-review?(colin.ogilvie)
Comment on attachment 186173 [details] [diff] [review]
Quoted

PHP Parse error:  parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting
T_STRING or T_VARIABLE or T_NUM_STRING in
/home/colin/public_html/update/developers/mail_approval.php on line 38
Attachment #186173 - Flags: first-review?(colin.ogilvie) → first-review-
Output from my test:

Scribblies Brite 1.0.9 - Approval Granted
Your item, Scribblies Brite 1.0.9, has been reviewed by a Mozilla Update editor
who took the following action:
Approval Granted

Please Note: It may take up to 30 minutes for your extension to be available for
download.

Your item was tested by Alan Starr using FX 1.0.4 on Win2k.
Editor's Comments:
 test by alanjstr.  Please contact him if you receive this.
Attached patch Move the quotesSplinter Review
Attachment #186173 - Attachment is obsolete: true
Attachment #186266 - Flags: first-review?(colin.ogilvie)
Attachment #186266 - Flags: first-review?(colin.ogilvie) → first-review+
Whiteboard: [landme]
Checking in developers/mail_approval.php;
/cvsroot/mozilla/webtools/update/developers/mail_approval.php,v  <-- 
mail_approval.php
new revision: 1.3.2.7; previous revision: 1.3.2.6
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.