293257 - Enable drag and drop from address book sidebar to addressing widget in compose window.

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Mark Banner (:standard8)]

Now we have the sidebar back in the compose window, we should also enable drag
and drop to the addressing widget. Should be fairly simple as the addressing
widget already accepts the drop.

Comment 1

[Mark Banner (:standard8)]

Attachment: Fix v1 (checked in)

This patch enables dnd from the sidebar to the compose addressing widget (I found out how tb did it). It sometimes doesn't separate multiple items onto different lines automatically - I think that's something to do with focus, but I've got no idea how to fix that. TB does it better, but its not perfect. Anyway, the user can always enter the line and press "enter".

Comment 2

[Mark Banner (:standard8)]

Attachment: Fix some warnings/assertions

This fixes a warning about an undefined variable and fixes some possible assertions when users try to do things like dragging random text to address books and expecting something to happen ;-)

Comment 3

[[e-mail]]

Comment on attachment 256086 [details] [diff] [review]
Fix some warnings/assertions

>+      try {
>+        trans.getAnyTransferData(flavor, dataObj, len);
>+      }
>+      catch (ex) {}
>+      if (!dataObj.value)
>+      {
>+        dragSession.canDrop = false;
>+        return false;
>+      }
Shouldn't this be
catch (ex) {
  dragSession.canDrop = false;
  return false;
}

>-      if (dataObj)
>+      if (dataObj.value)
I would be surprised if this failed - prefer try/catch if you want to be sure.

>+  var trans = Components.classes["@mozilla.org/widget/transferable;1"].createInstance(Components.interfaces.nsITransferable);
>+  trans.addDataFlavor("text/x-moz-address");
I've got no objection to you removing the try/catch but you could wrap the .createInstance while you're at it.

Comment 4

[[e-mail]]

Comment on attachment 256084 [details] [diff] [review]
Fix v1 (checked in)

D'oh!

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 256084 [details] [diff] [review]
Fix v1 (checked in)

I checked this into trunk. Neil implied on irc he thought it may be suiteable for 1.1.2 so I'm requesting approval.

Comment 6

[Mark Banner (:standard8)]

Attachment: Fix some warnings/assertions v2

v2 -> Fixes Neil's comments.

Comment 7

[Mark Banner (:standard8)]

Both patches checked in -> fixed.

Comment 8

[Robert Kaiser]

Comment on attachment 256084 [details] [diff] [review]
Fix v1 (checked in)

a=me for 1.1.2

Comment 9

[Mark Banner (:standard8)]

Checked in on 1.8 branch.