Closed
Bug 293265
Opened 19 years ago
Closed 19 years ago
Rename --enable-cairo to --enable-canvas
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tor, Assigned: tor)
References
Details
Attachments
(1 file, 1 obsolete file)
14.14 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Mozilla can use cairo for three different things (gfx, svg, and canvas), so naming the html:canvas option --enable-cairo is causing confusion based on what I've seen in #developers.
Attachment #182873 -
Flags: review?(benjamin)
Comment 3•19 years ago
|
||
Comment on attachment 182873 [details] [diff] [review] rename config option dnl check whether to enable cairo dnl ======================================================== MOZ_ARG_ENABLE_BOOL(cairo, Shouldn't the first parameter be changed from cairo to canvas too? As well as the comment.
Attachment #182873 -
Flags: review?(benjamin)
Attachment #182873 -
Attachment is obsolete: true
Attachment #183027 -
Flags: review?(benjamin)
Comment 5•19 years ago
|
||
Comment on attachment 183027 [details] [diff] [review] address Arron's comments Is this patch supposed to default canvas off?
Attachment #183027 -
Flags: review?(benjamin) → review+
I just left the default as it was before, off. Switching the default on canvas has the same problems as turning on svg by default right now - the build prereqs will turn most of -ports red. I think the thought is to just enable it explicity on the appropriate moz tinderboxes until the owners can be reminded of upcoming requirements.
Attachment #183027 -
Flags: approval1.8b2?
Comment 7•19 years ago
|
||
Comment on attachment 183027 [details] [diff] [review] address Arron's comments a=asa via rl. Let's get this on the trunk and I'll switch the build machines to use the new flag asap after it hits.
Attachment #183027 -
Flags: approval1.8b2? → approval1.8b2+
Checked in.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•