Closed
Bug 293276
Opened 20 years ago
Closed 20 years ago
Install button = download instead
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.1
People
(Reporter: ehume, Assigned: Bugzilla-alanjstrBugs)
References
()
Details
(Keywords: regression)
Attachments
(1 obsolete file)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
I had a user complaint about the install button on the display for SphereGnome
Jumbo. Sure enough, when you click on it, you get the Open/Save to Disk dialog
instead of the installation dialog. But the same is true for all of my themes:
Scribblies Brite, Kids and Plain; SphereGnome, SphereGnome Big and SphereGnome
Jumbo.
When you go to each theme's page, clicking on the Install Now button correctly
gives the installation dialog.
Reproducible: Always
Steps to Reproduce:
1. Open a page with one of my themes displayed on it, along with other themes.
2. Click on the Install button.
Actual Results:
Firefox offers to open or save the jarfile.
Expected Results:
Offer to install the theme.
Work around: click on the theme's name, go to the theme's page and click on the
Install Now button.
I wonder if the fix for bug 291616 will fix this.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: 1.0 → 1.1
Nope, that bug broke it.
Severity: normal → major
Keywords: regression
We're throwing JS errors.
http://lxr.mozilla.org/update1.0/source/themes/showlist.php#448
We should be calling installTheme() not install.
Status: NEW → ASSIGNED
Fix can be seen on
https://update-staging.mozilla.org/~alanjstr/themes/showlist.php?application=firefox&numpg=50&pageid=2
The php error is bug 290204, so ignore that bit.
Attachment #182917 -
Flags: first-review?(cst)
I just installed a theme from your update-staging page a few minutes ago. It
worked without a hitch with Firefox 1.0.3.
(In reply to comment #7)
> Now moreinfo.php is broken.
>
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/webtools/update/themes&command=DIFF_FRAMESET&root=/cvsroot&file=moreinfo.php&rev1=1.22.2.11&rev2=1.22.2.12
>
This is by design, in order to mitigate the Firefox security issue described in
bug 293302. I don't think we want to do anything about it until Firefox 1.0.4
is released.
*** Bug 295169 has been marked as a duplicate of this bug. ***
Comment on attachment 182917 [details] [diff] [review]
Use installTheme for non-TB
Obsoleting and cancelling the review request - I forgot about this and fixed
the actual bug myself just now (sorry!) when it was pointed out on umo-admins.
If some parts of this patch should still be landed (e.g. the code cleanup)
recreate the diff against current CVS and request review again.
Attachment #182917 -
Attachment is obsolete: true
Attachment #182917 -
Flags: first-review?(cst)
Comment on attachment 182917 [details] [diff] [review]
Use installTheme for non-TB
Obsoleting and cancelling the review request - I forgot about this and fixed
the actual bug myself just now (sorry!) when it was pointed out on umo-admins.
If some parts of this patch should still be landed (e.g. the code cleanup)
recreate the diff against current CVS and request review again.
Comment on attachment 182917 [details] [diff] [review]
Use installTheme for non-TB
Obsoleting and cancelling the review request - I forgot about this and fixed
the actual bug myself just now (sorry!) when it was pointed out on umo-admins.
If some parts of this patch should still be landed (e.g. the code cleanup)
recreate the diff against current CVS and request review again.
Comment on attachment 182917 [details] [diff] [review]
Use installTheme for non-TB
Obsoleting and cancelling the review request - I forgot about this and fixed
the actual bug myself just now (sorry!) when it was pointed out on umo-admins.
If some parts of this patch should still be landed (e.g. the code cleanup)
recreate the diff against current CVS and request review again.
Comment on attachment 182917 [details] [diff] [review]
Use installTheme for non-TB
Obsoleting and cancelling the review request - I forgot about this and fixed
the actual bug myself just now (sorry!) when it was pointed out on umo-admins.
If some parts of this patch should still be landed (e.g. the code cleanup)
recreate the diff against current CVS and request review again.
Excuse the large amount of spam... bugzilla was giving me a 500 and I didn't
realize it did commit the changes.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•