293301 - since 20050430: [Mac] rendering of text in non-western encodings is broken

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect, P1)

Description

[Asaf Romano (gone)]

Starting from 20050430, rendering of text in non-western encodings is broken.

My non-default font prefs are:
user_pref("font.default.x-western", "sans-serif");
user_pref("font.name.sans-serif.he", "Arial");
user_pref("font.name.sans-serif.x-western", "Arial");
user_pref("font.name.serif.x-western", "Lucida Grande");

(Note: I'm using the Windows version of Arial)

Comment 1

[Asaf Romano (gone)]

Attachment: Screenshot 1

That's http://ftp.mozilla.org/pub/mozilla.org/camino/releases/ in UTF-8...

Comment 2

[Asaf Romano (gone)]

Attachment: Screenshot 2

visual hebrew overlaps from
http://forums.ort.org.il/scripts/showm.asp?which_forum=307&back=

Comment 3

[Asaf Romano (gone)]

Attachment: Screenshot 3: broken alignment

Comment 4

[Asaf Romano (gone)]

..that was from http://www.haayal.co.il/

Comment 5

[Asaf Romano (gone)]

regression area: http://tinyurl.com/exjrk

CCing per relevant checkins.

Comment 6

[Robin Lu]

this might not be a mac only bug. I am on linux and found this site is also broken:
http://military.china.com/zh_cn/
and this link is reported by a windows user.

Comment 7

[Simon Fraser [no longer active]]

Looks like jshin's changes are the most likely culprit.

Comment 8

[Jungshik Shin]

(In reply to comment #7)
> Looks like jshin's changes are the most likely culprit.

Hmm. I've already considered that possibility, but I can't see how. Anyway, I'll
try to see if it's indeed the cause. 

Comment 9

[Jungshik Shin]

I confirmed that it's my patch that caused the regression. Some missing entries
in the mapping between our langGroup and script code appears to result in the
regression.

Comment 10

[Jungshik Shin]

Attachment: patch

thanks for catching the regression. 
asking for r/sr. sfraser, can you double as r/sr?

The regression was not due to what I added but due to what I forgot to add. I'm
adding them here.

Comment 11

[Jungshik Shin]

(In reply to comment #6)
> this might not be a mac only bug. I am on linux and found this site is also
broken:
> http://military.china.com/zh_cn/
> and this link is reported by a windows user.

I don't see what's wrong with the site on Windows/Linux. Please, file a separate
bug with a screenshot or two.

Comment 12

[Asaf Romano (gone)]

Comment on attachment 183011 [details] [diff] [review]
patch

r=mano

Comment 13

[Jungshik Shin]

Comment on attachment 183011 [details] [diff] [review]
patch

asking for a to trunk

This patch fixes the regression on Mac OS X introduced on April 29 (bug
237434). It's for Mac OS X only so that it doesn't affect other platforms. In
my original patch for bug 237434, I forgot to add a couple of array elements so
that there's an index mismatch between two arrays, which apparently caused this
bug.

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 183011 [details] [diff] [review]
patch

a=as

Comment 15

[Jungshik Shin]

thanks all. fix landed on the trunk