293371 - Some events lost during page load (Mouseup/Down)

Status: RESOLVED WORKSFORME

(Core :: DOM: Events, defect, P5)

Description

[Jens Bannmann]

Various extensions, one of them Optimoz Mouse Gestures, try to catch all
mousedown/up events so they always know the current button state. This is used
to implement Opera's click-only gestures (we call them "rocker gestures") where
you hold the right mouse button and click the left one to go back, or vice-versa
for going forward.

However, if the mouse button is released at a certain point while Mozilla loads
a new page (e.g. "Back" function invoked), the event is lost. That means that
the extension often believes the button is still down, and would trigger the
function again on each left-click.

{{ Currently, Optimoz Mouse Gestures includes measures to always reset its mouse
button state as soon as a page load gesture (mostly Back/Forward) is performed,
which prevents us from allowing multiple rocker invocations without releasing
the right mouse button (our most requested feature). The All-in-One-Gestures
extension implements an optional "Opera-style" mode that disables these, but
lets users run into the bug described above. }}


The proposed solution is to fire events during this period for chrome JS, but
only above the xul:browser element to prevent the new page's scripts from
getting "old" events.

Comment 1

[Jens Bannmann]

Attachment: test case as a stripped-down extension for firefox

I made a stripped-down version of Gavin Lynch's "rocker navigation" extension
to serve as a testcase (Optimoz Mouse Gestures' complexity makes that task too
cumbersome) and added debug output.

Instructions:
1) Download, install, and run Firefox
2) Load up about 5 pages consecutively (longer pages seem to make it easier to
reproduce the bug)
3) Hold down the right mouse button, click the left and quickly release both to
go back a page. The testcase shows its "believed" mouse button states in a
label below the status bar.
4) Repeat step 3 several times, until you end up with a wrong button state
(e.g. left and/or right button still believed to be "down")

Comment 2

[Jens Bannmann]

With Firefox 1.5b1 and bfcache enabled, the problem is still there. If anything,
it became more easily reproducible.

Comment 3

[djet]

Any plans to fix it in (at least) Fx 2.0? This bug makes all mouse gestures extensions inferior and buggy compared to according implementations in other browsers (Opera, Maxthon).

Comment 4

[Peter]

Very annoying bug. Please, fix it.

Comment 5

[noitidart]

This is also the case in FF 4b

Comment 6

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 7

[Andrei Purice]

Hey Jens,
Can you still reproduce this or should we close it? The test case isn't working for me.

Comment 8

[Jens Bannmann]

Hi Andrei,

thanks, but in the meantime I stopped working on addons in general. Let's just close this bug.

Comment 9

[Andrei Purice]

Marking this as Resolved > Worksforme based on the last comment.