293381 - On "Download/Sync now" status bar "Opening folder..." should include folder name

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Dave Aton]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-us) AppleWebKit/312.1 (KHTML, like Gecko) Safari/312
Build Identifier: 

During "Download/Sync now" the status bar says "Opening folder..." but does not tell the user which 
folder it's opening. The folder name should be included.

I'm using IMAP. Haven't tested with a POP account.

Reproducible: Always

Steps to Reproduce:
1. Click on File > Offline > Download/Sync now...
2. Check boxes for Mail Messages and Send Unsent messages
3. Click OK

Actual Results:  
Status bar says "Opening folder..." which flashes as (I presume) new folders are opened.

Expected Results:  
User should be informed of which folder is being opened. This will help to spot problems that may 
occur with a particular folder so they can be investigated later.

Comment 1

[Phil Ringnalda (:philor)]

*** Bug 293383 has been marked as a duplicate of this bug. ***

Comment 2

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 3

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.

Comment 4

[Dave Aton]

(In reply to comment #3)
> This bug has been automatically resolved after a period of inactivity (see above
> comment). If anyone thinks this is incorrect, they should feel free to reopen it.

Unresolved in Ver 1.0.6.

Comment 5

[Frédéric Buclin]

Confirming...

Comment 6

[Dave Aton]

Behavior remains unresolved in 2.0.0.5.

Comment 7

[Frédéric Buclin]

I know. That's why the bug is still open. :)

Comment 8

[Frédéric Buclin]

Attachment: patch, v1

Is it as simple as that?

Comment 9

[David :Bienvenu]

Comment on attachment 274708 [details] [diff] [review]
patch, v1

looks good, thx.

Comment 10

[David :Bienvenu]

Comment on attachment 274708 [details] [diff] [review]
patch, v1

actually, I think this is wrong %S means the string is PRUnichar, but you're passing in a char *...you probably want to get the unicode version of the mailbox name.

Comment 11

[Frédéric Buclin]

(In reply to comment #10)
> (From update of attachment 274708 [details] [diff] [review])
> actually, I think this is wrong %S means the string is PRUnichar, but you're
> passing in a char *...you probably want to get the unicode version of the
> mailbox name.

David, from what I see, ProgressEventFunctionUsingIdWithString() does it for us:

http://lxr.mozilla.org/mozilla/source/mailnews/imap/src/nsImapProtocol.cpp#4667

It takes a char * parameter and converts it to unicode using CopyMUTF7toUTF16() before passing it to m_imapMailFolderSink->ProgressStatus().

Comment 12

[David :Bienvenu]

Comment on attachment 274708 [details] [diff] [review]
patch, v1

ah, cool, sorry 'bout that. Thx for the patch.

Comment 13

[Frédéric Buclin]

Checking in mail/locales/en-US/chrome/messenger/imapMsgs.properties;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/imapMsgs.properties,v  <--  imapMsgs.properties
new revision: 1.10; previous revision: 1.9
done
Checking in mailnews/imap/src/nsImapProtocol.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsImapProtocol.cpp,v  <--  nsImapProtocol.cpp
new revision: 1.664; previous revision: 1.663
done
Checking in suite/locales/en-US/chrome/mailnews/imapMsgs.properties;
/cvsroot/mozilla/suite/locales/en-US/chrome/mailnews/imapMsgs.properties,v  <--  imapMsgs.properties
new revision: 1.47; previous revision: 1.46
done

Comment 14

[Marek Stępień [:marcoos, inactive]]

-5000=Opening folder...
+5000=Opening folder %S...

This is a semantic change that should require changing the property name, so that localizers are pinged about this.

CCing Pike.

Comment 15

[Axel Hecht [:Pike]]

Sadly we can't fix that. Could someone post to .l10n so that we at least announce this change?

Comment 16

[Marek Stępień [:marcoos, inactive]]

Why? Wouldn't changing 5000 to, say, 5105, and updating both the .properties file and nsImapStringBundle.h work? How is this different from bug 361433?

Comment 17

[Axel Hecht [:Pike]]

Is there any justification for the existance of nsImapStringBundle.h in the first place?

Comment 18

[Scott MacGregor]

oops, yeah we should have bumped the name of the string here since the string change is a semantic one. Sorry I didn't catch that during the review.