Closed
Bug 293400
Opened 20 years ago
Closed 20 years ago
nspr.def has an extra blank line at the end
Categories
(NSPR :: NSPR, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 292899
4.6
People
(Reporter: abwillis1, Assigned: wtc)
Details
Attachments
(1 file)
|
371 bytes,
patch
|
wtc
:
review+
shaver
:
approval-aviary1.1a1+
shaver
:
approval1.8b2+
|
Details | Diff | Splinter Review |
An extra blank line at the end of nspr.def is causing an error when building on OS/2. It creates a line in the nspr4.def as _ @387 RESIDENTNAME which creates an unresolved external of "_". Patch to follow.
|
Reporter | |
Comment 1•20 years ago
|
||
|
Assignee | |
Comment 2•20 years ago
|
||
Thanks for the bug report and fix. We are working on it. *** This bug has been marked as a duplicate of 292899 ***
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
|
|
Assignee | |
Comment 3•20 years ago
|
||
Comment on attachment 182975 [details] [diff] [review] removes extra blank line r=wtc. Requesting NSPRPUB_PRE_4_2_CLIENT_BRANCH checkin approval for Mozilla 1.8b2 and Avaiary 1.1a1. This patch removes an extraneous blank line at the end of the nspr.def file that breaks the OS/2 build. It is a build bustage fix.
Attachment #182975 -
Flags: review+
Attachment #182975 -
Flags: approval1.8b2?
Attachment #182975 -
Flags: approval-aviary1.1a1?
|
||
Comment 4•20 years ago
|
||
Comment on attachment 182975 [details] [diff] [review] removes extra blank line a=shaver for build fix.
Attachment #182975 -
Flags: approval1.8b2?
Attachment #182975 -
Flags: approval1.8b2+
Attachment #182975 -
Flags: approval-aviary1.1a1?
Attachment #182975 -
Flags: approval-aviary1.1a1+
|
|
Assignee | |
Comment 5•20 years ago
|
||
Fix checked in on the NSPR trunk (NSPR 4.6) and the NSPRPUB_PRE_4_2_CLIENT_BRANCH (Mozilla 1.8 Beta 2).
Target Milestone: --- → 4.6
You need to log in
before you can comment on or make changes to this bug.
Description
•