293419 - When upgrading from 1.0 to 1.1 ext's that are compatible based on their update.rdf do not work

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

Comment 1

[Robert Strong (they/them - no direct email)]

The following is shown in the js console when upgrading from 1.0 to the latest
trunk with adblock installed. adblock's install.rdf has a maxVersion of 0.10 and
its update.rdf has a maxVersion of 10.0. It appears that phone homw does not
occur for extensions installed by dropping a directory into the extensions
directory.

Item Installed via directory addition to Install Location: app-profile Item ID:
{34274bf4-1d97-a289-e984-17e546307e4f}, attempting to register...

Item Installed/Upgraded at Install Location: app-profile Item ID:
{34274bf4-1d97-a289-e984-17e546307e4f}, attempting to register...

... failure, item is not compatible, error: Incompatible Version

Comment 2

[sairuh (rarely reading bugmail)]

see also bug 286299 comment 0.

Comment 3

[Robert Strong (they/them - no direct email)]

i have seen(In reply to comment #2)
> see also bug 286299 comment 0.
Seen it. The difference is this bug is to fix the issue with the item being
uninstalled while bug 286299 is to fix the issue with "the Extensions dialog
doesn't go away".
I already have a patch for this bug and I am waiting on the freeze to lift so I
can land several other patches first.

Comment 4

[Robert Strong (they/them - no direct email)]

I will attach the patch I have for this bug this evening and what it will do is
install the extension and disable it. This way during the next check it will
enable the extension if it has an externally raised maxVersion in its update rdf.

ONE VERY IMPORTANT NOTE. One aspect of this bug is that the extension's
install.rdf is not updated with the target app's minVersion and maxVersion
during the compatibility update and this is fixed by the patch in bug 267906.
Without the patch for bug 267906 it is possible that a user will go through the
extension being disabled again if the extensions.rdf is ever rebuilt. I realize
that the patch in bug 267906 is fairly significant to consider landing for 1.8b2
but without it there may very well be a bunch of reports about extensions being
disabled.

Comment 5

[Robert Strong (they/them - no direct email)]

I borrowed a Mac and spent the evening trying to isolate the problems for bug
295729 and bug 295732 since I have limited access to a Mac system. I'll submit
the patch as soon as I am able later today.

Comment 6

[Benjamin Smedberg]

Asa, I really don't think this is a 1.1a1 blocker: any patches for this bug
would IMO be too risky for the relatively minor inconvenience of this bug.

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch

I concur with you Benjamin regarding the risk to value ratio for this patch but
here it is anyways. All it does is add a case for installing an incompatible
item that uses the same code as installing a compatible item with the addition
of disabling the item as well.

Comment 8

[Benjamin Smedberg]

Comment on attachment 184807 [details] [diff] [review]
patch

If 1.1a1 is not done, I'd like to get this in.

Comment 9

[chris hofmann]

Comment on attachment 184807 [details] [diff] [review]
patch

a=chofmann for alpha1

Comment 10

[Benjamin Smedberg]

Fixed on trunk.

Comment 11

[Peter van der Woude [:Peter6]]

*** Bug 296804 has been marked as a duplicate of this bug. ***