293437 - xforms-model-construct event handler not firing

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

We are properly generating the xforms-model-construct event and targeting the
model, but the event handler doesn't get hit.  Probably a timing bug?  We need
to figure this out to pass a conformance test.

Comment 1

[aaronr]

Attachment: testcase

should see a modal message popup when the form is loaded

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

I think the xforms-model-construct event is dispatched before XML Events
handlers are registered. So xforms-model-construct should be dispatched after
DOMContentLoaded.

Comment 3

[aaronr]

Attachment: first attempt at fix

I basically had to move xforms-model-construct, xforms-rebuild,
xforms-recalculate, xforms-revalidate to after DOMContentLoaded event was
detected because of the XML Event listener registration not happening until
after document load.  Had to move rebuild, recalc and revalidate because they
were in the same boat as xforms-model-construct....event handlers not firing
during load.

Comment 4

[Allan Beaufour]

Comment on attachment 183610 [details] [diff] [review]
first attempt at fix

Ooops, sorry Aaron, I didn't see the request.

>@@ -281,16 +272,17 @@ nsXFormsModelElement::DoneAddingChildren
>+      nsresult rv;

Initialize it to get rid of the compiler warning.

>@@ -765,16 +757,30 @@ nsXFormsModelElement::HandleEvent(nsIDOM
>+  // dispatch xforms-model-construct, xforms-rebuild, xforms-recalculate, 

Delete bonus space at end of line.

r+

Comment 5

[aaronr]

Comment on attachment 183610 [details] [diff] [review]
first attempt at fix

Doron, could you do the second review?	And could you add Allan's nits and
check in if you don't find anything else yourself?  Since I'll be out of the
office for a while...

Comment 6

[Allan Beaufour]

Checked in.