293445 - In message filter rules 'from' keyword gets replaced by 'sender' after restart.

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[atus]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.0.3705)
Build Identifier: version 1.0.2 (20050317)

If you create a message filter rule using 'From' header value as the filter, it 
gets replaced by 'sender' after a restart. Mails that have both from, and 
sender header field (with different value) will stay in Inbox, or goes to wrong 
folder.

Reproducible: Always

Steps to Reproduce:
1. Create a message filter rule by using a header value 'from'. (you should add 
it first, because only sender exist) eg: if 'from' contains foo move the 
message to folder: bar.

2. Create a dummy message that has a 'from: [e-mail]' and a 'sender: 
[e-mail]' header field. Check, that the filter works right. (it should 
work at first)

3. Close Thunderbird, and open it again.

4. Put the message back to the inbox, and aply the previously generated filter. 
It will not work. Look at filter preferences, and see that 'From' field gets 
replaced by 'sender'.
The replace not only occure at restart, but after a lot of time too, but I 
can't say the exact period.
Actual Results:  
As I described in the problem field. After restart, some messages stay in 
Inbox, istead of goes to the right folder.

Expected Results:  
Filter as I set the rule in the firs place.

none

Comment 1

[atus]

Attachment: sample mail to repro the bug.

sample mail to repro the bug.

Comment 2

[David :Bienvenu]

I changed the filter ui to say from - I didn't think that affected the filter
backend at all - picking sender before the change, and from after the change,
both filtered on the "from" header.

Comment 3

[David :Bienvenu]

this works fine for me - we always wrote "from" in the filter file, but showed
it as "sender" in the UI.  In 1.1, we show it as "from" in the UI.

Comment 4

[atus]

(In reply to comment #3)
> this works fine for me - we always wrote "from" in the filter file, but showed
> it as "sender" in the UI.  In 1.1, we show it as "from" in the UI.

Please use the letter I sent as an attachment. It has both 'from' and 'sender' 
header field:

----------
RT-Originator: [e-mail]
Sender: <[e-mail]>
From: "Ludman Zoltán" <[e-mail]>
Managed-BY: Request Tracker 2.0.13 (http://www.fsck.com/projects/rt/)
RT-Ticket: 2FRobot #28484
----------

When the filter rule shows 'from', it works, and put the message in the right 
folder. When it shows 'sender', it leaves the message in the inbox. (I assume 
because there IS a sender filed too)

The rule I use:
When 'from' contains '[e-mail]' put it to another folder.

Please test it.

BR,
Attila Kadar 

Comment 5

[Jestre]

Confirming filter fails when using 'From' or '"From"' when run from Menu
"Tools\Run Filters on folder.
It works after initial editing in 'Filter Rules' setting to custom '"From"' and
then selecting 'Run Now' button from 'Message Filters' window setting it to
custom header "From". See filter as copied from my .dat file below.
It will fail after closing and restarting TB.

If condition="OR (from,ends with,.ua>)"
it always fails from either the menu or the 'Run Now' button.

--- From 'msgFilterRules.dat'
name="test"
enabled="yes"
type="1"
action="Move to folder"
actionValue="mailbox://[e-mail]/Inbox/test2"
condition="OR (\"From\",ends with,.ua>)"
---

--- From 'Inbox.sbd\test'
From: Oeagrus <[e-mail]>
---

version 1.0+ (20050531), Win XP, PTB

Comment 6

[Jestre]

(In reply to comment #5)

The From: filter ingores the trailing '>' in the From: Header.
If the rule is changed to:
> condition="OR (\"From\",ends with,.ua)"
it starts to works even though the > is present in the header and not the search
string.
The filters are working for me with this change.
Also Sender: is no longer replacing From: in current builds.

Jestre

Comment 7

[Wayne Mery (:wsmwk)]

WFM per reporter.  If this is incorrect and it is failing on a current version, please comment and reopen the bug.