293472 - Remove unused images from classic.jar in Firefox and Thunderbird

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Simon Paquet [:sipaq]]

The files

- menu-arrow.gif
- menu-arrow-disabled.gif
- menu-arrow-hover.gif

are still packaged for Thunderbird and Firefox, even though they aren't used
anymore and have been replaced by equivalent png-files. The only exception is
the use of menu-arrow.gif in 

http://lxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/global/menu.css#92

Comment 1

[Simon Paquet [:sipaq]]

There are more unused files:

- alert-error.gif
- alert-exclam.gif
- alert-message.gif
- alert-question.gif

Comment 2

[Simon Paquet [:sipaq]]

Found one more in Qute (Thunderbird theme on Windows and Linux):

- tab-new.gif

Comment 3

[Simon Paquet [:sipaq]]

Attachment: Qute cleanup patch

Cleanup patch for Qute. The unused files should be cvs removed after applying
this patch.

Comment 4

[Simon Paquet [:sipaq]]

Attachment: Winstripe cleanup patch

Cleanup patch for Winstripe. The unused files should be cvs removed after
applying this patch.

Comment 5

[Simon Paquet [:sipaq]]

Ok, found one more:
close-button.gif is not used in Pinstripe and Winstripe. Qute uses it but does
not use close.gif instead. Question is, should Qute move to close.gif instead of
close-button.gif so that we could remove the reference to close-button.gif in
all three themes?

Mike and Scott, can you give some guidance here, please!

Comment 6

[Simon Paquet [:sipaq]]

And what about Throbber-small.gif here:
http://lxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/throbber/Throbber-small.gif

We have in mozilla/toolkit, but we don't call it anywhere. All references to it
(even from files in mozilla/toolkit) go to
http://lxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/Throbber-small.gif
(see http://lxr.mozilla.org/seamonkey/search?string=throbber-small.gif). This is
evil in itself, because we create unnecessary dependencies on mozilla/browser
from mozilla/toolkit.

I propose just using the file in mozilla/toolkit in all Firefox-specific code.
This would also allow other Toolkit apps, like Sunbird for example, to stop
packaging that file separately.

Comment 7

[Simon Paquet [:sipaq]]

Attachment: Qute cleanup patch v2 (checked in)

Scott, this is a pretty low-risk patch, which disables packaging of some unused
files (which should also be cvs removed). It also moves Qute, Pinstripe and
Winstripe nearer together, by removing the reference to close-button.gif (see
comment 5).

Comment 8

[Simon Paquet [:sipaq]]

Comment on attachment 184175 [details] [diff] [review]
Qute cleanup patch v2 (checked in)

Asking for approval. This is a low-risk cleanup patch which removes some unused
files from the build. It should save around 4K of build size on Windows

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 184175 [details] [diff] [review]
Qute cleanup patch v2 (checked in)

moving request out to a2. we're wrapped on a1.

Comment 10

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 184175 [details] [diff] [review]
Qute cleanup patch v2 (checked in)

a=shaver.

Comment 11

[Simon Paquet [:sipaq]]

Comment on attachment 184175 [details] [diff] [review]
Qute cleanup patch v2 (checked in)

Patch was checked in by timeless.

Comment 12

[Simon Paquet [:sipaq]]

Attachment: Winstripe cleanup patch v2

Mike, could you review this cleanup patch, please.
I'm also asking mvl for a second review, because the patch touches Sunbird's
Winstripe code.

Comment 13

[Simon Paquet [:sipaq]]

Attachment: Winstripe cleanup patch v3 (at mconnor's request)

Comment 14

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 185366 [details] [diff] [review]
Winstripe cleanup patch v3 (at mconnor's request)

Sorry, i'm not a sr, so i can sr this.
If you want to change sunbird's throbber, i'd suggest to file a new bug.

Comment 15

[Mike Connor [:mconnor]]

Comment on attachment 185366 [details] [diff] [review]
Winstripe cleanup patch v3 (at mconnor's request)

Are we packaging two copies of Throbber.gif too?  Yes, we're not using it in
Firefox, but it should live in toolkit only, since its fairly generic.

Sorry for the delay, falling asleep in my chair mucks with my short-term
memory...

Comment 16

[timeless]

Comment on attachment 184175 [details] [diff] [review]
Qute cleanup patch v2 (checked in)

2005-06-03 14:57
mozilla/mail/themes/qute/mail/compose/messengercompose.css	1.3
mozilla/toolkit/themes/qute/global/printing.css 	1.3
mozilla/toolkit/themes/qute/global/jar.mn	1.10

Comment 17

[Simon Paquet [:sipaq]]

Attachment: Same patch as before but without the Sunbird changes (checked in)

Same patch as before but without the Sunbird changes, which I was asked to move
into another bug. Carrying over mconnor's review, since the changes to
mozilla/browser and mozilla/toolkit do not depend on the Sunbird changes and
nothing was changed between the prior patch and this one.

Comment 18

[Simon Paquet [:sipaq]]

Comment on attachment 185652 [details] [diff] [review]
Same patch as before but without the Sunbird changes (checked in)

Asking for approval on a small low-risk cleanup patch.

Comment 19

[Simon Paquet [:sipaq]]

The last patch was checked in by mvl. Marking FIXED.