Closed Bug 293523 Opened 16 years ago Closed 16 years ago
Change "Edit Popup Blocker Options
..." to "Edit Popup Blocker Preferences ..." on Mac/Linux
...for consistency with naming conventions.
I forgot to mention it in the original report, but this string is displayed in the menu available by clicking on the info bar when a popup has been blocked. I ran across this issue while reviewing a patch for bug 292269. Note also that I added a small note next to the entities to describe the reason for having two separate entities. It's just an SGML comment, tho, because I don't know the format for location-specific l10n notes in DTDs if one exists. If there is one, let me know and I'll fix it on checkin.
Assignee: nobody → jwalden+fxhelp
Status: NEW → ASSIGNED
Trunk now displays a button title "Options" in the info bar for blocked popups, so I platformized that in this updated patch, which works fine for me in Linux. On a side note, there are a lot of these "Options" instances in non-platformized code...perhaps I'll file a bug later to clean them all up in one swell foop. For now, tho, I just want to fix this.
Comment on attachment 185513 [details] [diff] [review] Also platformize the "Options" button that now displays on the info bar r-, for the simple reason that this patch just makes extra work for translators for no good reason. Keep the existing strings the same, add a *Unix variant instead of renaming everything. General principle only, but I'd rather establish the principle now as opposed to later. Not to mention that out-of-date translations won't break for as many users in the meantime, giving us better testing, in theory.
Attachment #185513 - Flags: review?(mconnor) → review-
(In reply to comment #3) > Keep the existing strings the same, add a *Unix variant instead of renaming > everything. General principle only, but I'd rather establish the principle > now as opposed to later. Fair enough. I was just going for accuracy here and was trying to follow the style for Windows-specific strings, for what it's worth.
Comment on attachment 185518 [details] [diff] [review] Previous patch, with problems addressed Yeah, I know, its one of those little things that we do either way, bug in browser.dtd there's more *Unix than *Win, including the preferences accesskeys/strings at http://lxr.mozilla.org/mozilla/source/browser/locales/en-US/chrome/browser/brow ser.dtd#166
Attachment #185518 - Flags: review?(mconnor) → review+
Attachment #185518 - Flags: approval-aviary1.1a2?
Attachment #185518 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Attachment #185518 - Attachment description: Previous patch → Previous patch, with problems addressed
Patch checked in, marking FIXED. Updating Help docs is bug 296990, for what it's worth.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.1
You need to log in before you can comment on or make changes to this bug.