293544 - 2D Context needs to not hold pointer after Release

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Right now, CanvasRenderingContext2D does this:

    mDOMCanvasElement = aCanvasElement;
    if (mDOMCanvasElement) {
        if (NS_SUCCEEDED (CallQueryInterface(mDOMCanvasElement, &mCanvasElement)
)) {
            // don't hold a ref to this!
            mCanvasElement->Release();
        }
    } else {
        mCanvasElement = nsnull;
    }

to have "weak" refs to both the nsIDOMHTMLCanvasElement and nsICanvasElement
interfaces.  The method should take both as params, instead of doing
CallQI/Release().

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Why do you need mDOMCanvasElement at all? Just QI to nsIDOMHTMLCanvasElement in
the few places you need it and remove the member.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Patch for this in bug 293267's speedup patch.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Checked in with 293267.