293545 - Need ability to publish calendars in lightning

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stuart Parmenter]

We need to publish calendars in lightning...

Comment 1

[Stuart Parmenter]

Attachment: New dialog, js, hookups, etc

This patch refactors the old publishDialog* out of resources/content and puts
updated versions in content/base.  it adds some utility functions for opening
the dialog and doing all the real publish work.  it adds a context menu to
lightning to publish.

Comment 2

[Stuart Parmenter]

Attachment: better patch with fewer files and better error checking

I removed calendar-publish.js and moved the actual publish code in to
calendar-publish-dialog.js so that it could actually do error handling

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 183108 [details] [diff] [review]
better patch with fewer files and better error checking

OK, yeah, let's get that in.  Can you file a bug on better error handling (for
aStatus that's not a success code)? r=shaver, looking for second from mvl on
publishing details.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 183108 [details] [diff] [review]
better patch with fewer files and better error checking

>Index: base/content/calendar-publish-dialog.js

Can you make sunbird use this file too, and remove the old version? (Or file a
bug to make that happen)

>+/* helper functions */
>+function getCalendarManager()
>+function makeURL(uriString)

Why not use the helper functions from calendarUtils.js?

>Index: base/content/calendar-publish-dialog.xul
>+          <textbox flex="1" id="publish-remotePath-textbox" onkeypress="checkURL()"/>

Don't forget to port the patch fig bug bug 290736. (oninput instead of
onkeypress)

r=mvl

Comment 5

[Stuart Parmenter]

checked in.

I've filed bug 293710 for sunbird.

Comment 6

[Simon Paquet [:sipaq]]

Comment on attachment 183101 [details] [diff] [review]
New dialog, js, hookups,  etc

Patch is obsolete