293579 - xforms-value-changed, other events targeting every xf control

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

In sect. 4.1 in the spec, it says:  Throughout this chapter, each reference to
"form control" as a target element is a shorthand for any of the following
elements: input, secret, textarea, output, upload, trigger, range, submit,
select, select1, or group.

We aren't currently this particular.  We are sending xforms-value-changed to
switch and label, for example.

Comment 1

[aaronr]

Attachment: testcase

This testcase shows xforms-value-changed going to xf:switch and xf:label and
this shouldn't be the case.

Comment 2

[aaronr]

Attachment: first attempt

this fix introduces a new function to nsIXFormsControl interface called
isEventTarget.	When the xforms events that target form controls pass through
nsXFormsUtils::DispatchEvent, it calls isEventTarget on the control.  The
default is true, but when the target is a switch, label, repeat or
repeatItemElement, I return false.  When false is returned, the event is NOT
sent to the target.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 183701 [details] [diff] [review]
first attempt

>+  nsCOMPtr<nsIXFormsControl> control = do_QueryInterface(aTarget);
>+  if (control) {
>+    switch (aEvent) {
>+      case eEvent_Previous:
>+      case eEvent_Next:
>+      case eEvent_Focus:
>+      case eEvent_Help:
>+      case eEvent_Hint:
>+      case eEvent_DOMActivate:
>+      case eEvent_ValueChanged: 
>+      case eEvent_Valid:
>+      case eEvent_Invalid:
>+      case eEvent_DOMFocusIn:
>+      case eEvent_DOMFocusOut:
>+      case eEvent_Readonly:
>+      case eEvent_Readwrite:
>+      case eEvent_Required:
>+      case eEvent_Optional:
>+      case eEvent_Enabled:
>+      case eEvent_Disabled:
>+      case eEvent_InRange:
>+      case eEvent_OutOfRange:
>+        {
>+          PRBool acceptableEventTarget;

s/;/ = PR_FALSE;/

>+          control->IsEventTarget(&acceptableEventTarget);
>+          if (!acceptableEventTarget) {
>+            return NS_OK;
>+          }
>+          break;
>+        }

      default:
	break;

With those r=me

Comment 4

[aaronr]

Attachment: fixed comments

fixed smaug's review comments.	Can you do second review Allan?

Comment 5

[Allan Beaufour]

Comment on attachment 183775 [details] [diff] [review]
fixed comments

>+  NS_IMETHOD IsEventTarget(PRBool* aOK);

At some places you use "PRBool* aOK" and at other places "PRBool *aOK". Please
be consistent. Our code is generally using the latter. I'll fix that and a typo
in the comment in the IDL, and check it in for you.

Comment 6

[Allan Beaufour]

Checked in.