29359 - Search.dll is loaded on startup

Status: VERIFIED INVALID

(Core :: XPCOM, defect, P3)

Description

[Suresh Duddi (gone)]

The search dll is being loaded on startup. This is xp. I see this on windows 
and unix. Rjc is seeing it on mac.

Subject: 
            Re: libsearch.so loaded on startup
       Date: 
            Fri, 25 Feb 2000 17:34:42 -0800
       From: 
            [e-mail] (Chris Waterson)
         To: 
            [e-mail]
         CC: 
            Suresh Duddi <[e-mail]>
 References: 
            1 , 2




Is this XP? Or Mac-only? My guess is that this is due to my change from
about a week ago to build whatever frames layout asked for.

chris


Robert Churchill wrote:
> 
> Hey guys,
> 
> It looks like we *are* now reading in IE Favorites (as well as all the
> search datasets) on startup, instead of deferring like we used to.
> 
> At first glance, it looks like nsXULDocument is being really eager in
> terms of building up RDF-generated menu content.
> 
> Chris, it looks like you might know more about this from the CVS
> logs.  :^)   What's the purpose of ResumeWalk() et.al. ?
>

Comment 1

[Suresh Duddi (gone)]

Robert, I am assigning this to you hoping you would help waterson solve this. 
He already has a few pdt+ and a ton of mozilla+ issues to deal with :-)

Comment 2

[Robert John Churchill]

If this is a big startup slowdown (how much time are we losing, DP?), first 
thought: can we back out the code change?  ;^P

Comment 3

[Robert John Churchill]

*** Bug 29363 has been marked as a duplicate of this bug. ***

Comment 4

[Robert John Churchill]

I've marked the other bug (IE Favorites being loaded at startup) as a DUP of 
this bug, DP.

Comment 5

[Robert John Churchill]

OK, I'm whimping out on this and giving this bug to Chris so see what he wants 
to do regarding this. (Fix/back-out/ignore)

The biggest hit is on the Mac of course, as it has to:

1) read in favorites.html  (On Windows, nothing needs to be read in, as IE 
Favorites are stored in the file system)
2) read in all the Sherlock files (not just the ones we ship with, but with all 
the files including with the OS as well)

Item #1 appears to be about 1/10th of a second on my Powerbook.
Item #2 appears to be 3 or 4 seconds (yikes!) on my Powerbook.

Comment 6

[Suresh Duddi (gone)]

Nominating for beta1 based on timing reported. Remember robert is reporting 
timing on a real good powerbook.

Comment 7

[Jim Roskind]

Please indicate if there is an easy fix to delay the loading.  Even better would 
be a fix in hand, but a plan for an easy fix would be very attractive.
Thanks,
Jim

Comment 8

[leger]

Putting on PDT- for beta1. Please put make on PDT radar when you'all have a plan 
:-)

Comment 9

[Robert John Churchill]

*** Bug 35789 has been marked as a duplicate of this bug. ***

Comment 10

[Blake Ross]

adding perf kw..

Comment 11

[Robert John Churchill]

*** Bug 35789 has been marked as a duplicate of this bug. ***

Comment 12

[Chris Waterson]

search.dll is loaded on startup because it's included in the "datasources=" tag
for both the personal toolbar and the bookmarks menu. I've discussed with rjc,
and he feels that we should leave it there. Marking as INVALID for this reason.

FWIW, I've set a breakpoint in InternetSearchService::DeferredInit(), which
should be called when the first search is issued. I'm never seeing it hit.

Comment 13

[Blake Ross]

vrfy