293596 - Chatzilla URL munger rule needs tweaking for ending punctuation

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Glen Mailer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3

The difficulty with the regular expression is that in a perfect world, it would
have to differentiate between punctuation and URL characters.

At the moment padding the end of the URL with a bunch of punctuation the munger
grabs them, the following URLs break:
<http://google.com>;
http://www.google.com<>
and some daft examples:
<http://google.com>;;;;<<::
http://google.com}}}:<<;

-- Patch on the way --

Reproducible: Always

Steps to Reproduce:
1. Type the URLs above

Actual Results:  
All the punctuation at the end is munged

Expected Results:  
only the actual URLs should be

Comment 1

[Glen Mailer]

Attachment: Patch for new linkRE

Uses a word boundary and an exceptions list instead of the inclusion list of
the previous one.

Comment 2

[:Gijs (he/him)]

Confirming. 

Comment 3

[James Ross]

Comment on attachment 183148 [details] [diff] [review]
Patch for new linkRE

I don't know how it works, but it does.

r=silver

Comment 4

[:Gijs (he/him)]

Comment on attachment 183148 [details] [diff] [review]
Patch for new linkRE

Requesting approval for harmless CZ patches

Comment 5

[Mike Shaver (:shaver emeritus)]

Comment on attachment 183148 [details] [diff] [review]
Patch for new linkRE

a=shaver, but only because silver's the one who has to maintain the code that
monster regex is going into without commentary, and he r+'d it!

Comment 6

[James Ross]

I added a few lines of comment to this, appologies to shaver for making him read
that regexp without warning. :)

Checked in -> FIXED.