293641 - xulrunner build fails on Linux systems with bash 2.0x

Status: RESOLVED WORKSFORME

(Toolkit Graveyard :: XULRunner, defect)

Description

[Manfred Haertel]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050419
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050507

xulrunner can not be built on Linux systems with a bash shell older than 3.00 .

The problem is the following section in Makefile.in :

        @echo "Building tools from tier 2/9/50"
        @$(EXIT_ON_ERROR) \
        for d in $(tier_2_dirs) $(tier_9_dirs) $(tier_50_dirs); do \
            $(UPDATE_TITLE) \
            $(MAKE) -C $$d tools; \
        done;

When building xulrunner all variables after "in" are empty, so after
substitution, we get something like:

for d in ; do something ; done

This is a valid command line in bash 3.00, but not in 2.0x (I tried several
versions). Older bash version require something between "in" and the semicolon.

xulrunner builds, when I remove the section mentioned above from the Makefile .

Reproducible: Always

Steps to Reproduce:
1. Build xulrunner. I was using a mozconfig like the following:

. /somepath/mozilla/xulrunner/config/mozconfig
mk_add_options MOZ_OBJDIR=/somepath/xulrunner
ac_add_options --enable-default-toolkit=gtk
Actual Results:  
Build failure:

make[4]: Entering directory `/somepath/xulrunner/js/src/fdlibm'
/bin/sh: -c: line 1: syntax error near unexpected token `;'
/bin/sh: -c: line 1: `for d in ; do   /usr/bin/gmake -C $d libs;  done'
gmake[4]: *** [tools] Error 2
gmake[4]: Leaving directory `/somepath/xulrunner/js/src/fdlibm'
gmake[3]: *** [tools] Error 2
gmake[3]: Leaving directory `/somepath/xulrunner/js'gmake[2]: *** [tier_50] Error 2
gmake[2]: Leaving directory `/somepath/xulrunner'
gmake[1]: *** [default] Error 2
gmake[1]: Leaving directory `/somepath/xulrunner'
gmake: *** [build] Error 2 

Expected Results:  
Build xulrunner ;-)

Comment 1

[Benjamin Smedberg]

This doesn't make sense: none of tier_2_dirs tier_9_dirs or tier_50_dirs should
be empty:

http://lxr.mozilla.org/mozilla/source/Makefile.in#135

Comment 2

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/