29367 - OnStopRequest() not getting called with NS_ERROR_CONNECTION_REFUSED

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

when I fixed #26773, added support for alerts when the protocols OnStopRequest()
got called with aStatus == NS_ERROR_CONNECTION_REFUSED or NS_ERROR_NET_TIMEOUT

but, when I went to test it, I never saw OnStopRequest() getting called with
those values.

the result:  if the user's mail/news server request to connect times out or is
refused, the user will not get an alert.

Comment 1

[Richard Zach]

On sending mail, this can result in loss of data (user not warned that sending
message failed when server refused connection). Upping to major.

Note: I did see a connection time out warning on sending mail on Linux build
2000.02.26.08.

Comment 2

[Warren Harris]

Is this a general necko problem, or particular to a mail/news protocol?

Comment 3

[Judson Valeski]

I just verified that this still works in HTTP (try to access
http://obob.netscape.com). I'm not sure what the problem could be. Are you sure
you're hitting a server that is refusing connection or timing out?

Comment 4

[Richard Zach]

I see a time out both on http and in mail.  When the server refuses the
connection, I don't get an error. Try http://h2so4.dhs.org/ .  Console says
  Document http://h2so4.dhs.org/ loaded successfully
although I sure as hell have port 80 closed.

Comment 5

[(not reading, please use [e-mail] instead)]

changing summary, connection timed out is working.

Comment 6

[(not reading, please use [e-mail] instead)]

here's proof of the connection refused problem

$ telnet sspitzer 11
Trying 208.12.40.110...
telnet: Unable to connect to remote host: Connection refused

from 4.x, http://sspitzer:11
you get an alert about access to the port given has been disabled for security
reasons.

from 5.0, nothing loads, and on the console you get 
Document http://sspitzer:11/ loaded successfully

this be re-assigned to one of you necko gurus.

Comment 7

[(not reading, please use [e-mail] instead)]

re-assign to warren.

Comment 8

[Warren Harris]

=> valeski

Comment 9

[selmer (gone)]

Mass moving to M16 to get these off the M15 radar.  Please let me know if this
is really an M15 stopper.

Comment 10

[Judson Valeski]

hmm. This used to work. I've added (attachment) an extra case to catch the _HUP
signal and this is working for me on windows and linux. I haven't tested
mail/news though, can someone please test the patch in that scenario.

Comment 11

[Judson Valeski]

Attachment: proposed fix

Comment 12

[Judson Valeski]

fix is in.

Comment 13

[Judson Valeski]

fix is out. I think this was causing some unpleasantness in today's builds.

Comment 14

[Judson Valeski]

fixed.