293755 - "image" attribute on prefpane element doesn't work (typo)

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect)

Description

[Teune van Steeg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3

When you specify the image attribute in a prefpane, like:
<prefpane image="chrome://myExtension/skin/myImage.png">

The pane button associated with that prefpane will not contain that image.

Reproducible: Always

Steps to Reproduce:
1.Create an extension with preferences a la prefWindow V 
2.define a image on the image attribute on a prefpane
3.notice that the pane button will not contain the image when opening the
extensions preference dialog

Actual Results:  
No image shows on the pane button

Expected Results:  
The pane button should contain the image specified by the prefpane's image attribute

Will add patch soon

Comment 1

[Teune van Steeg]

Attachment: fix to use the correct inheritance/attribute on the pane button image

Patch so the correct attribute is inherited (and set) on the pane button
binding
in preferences.xml

Comment 2

[Nickolay_Ponomarev]

I believe it's supposed to be "image=src". I'd also try to catch someone on IRC
to get this reviewed before august :)

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 183284 [details] [diff] [review]
fix to use the correct inheritance/attribute on the pane button image

Please request approval when reviews have been granted.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 183284 [details] [diff] [review]
fix to use the correct inheritance/attribute on the pane button image

this seems wrong, shouldn't it be inherits src=image, if image is the attribute
you're looking to use here?

is panebutton image="" even supported? better to email ben since he hasn't
written docs yet..

Comment 5

[Teune van Steeg]

(In reply to comment #4)
> (From update of attachment 183284 [details] [diff] [review] [edit])
> this seems wrong, shouldn't it be inherits src=image, if image is the attribute
> you're looking to use here?
> 
For every prefpane a panebutton is created on preference window load:
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/preferences.xml#508

The pane button (actually a radio button) is created and when a image is
specified
(http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/preferences.xml#921)
the src attribute of the pane(=radio) button is set to the value of that image
attribute:
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/preferences.xml#542

that created radio button (pane button) has a binding associated with it: 
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/preferences.xml#1019

And because the src attribute is set to that radio button (and not the image
attribute), in the panebutton binding the src attribute of the image child is
inherited (and not the src=image).

In short: the image attribute of the prefpane element is inherited to the src
attribute on a radio button. And that radio button has a binding (prefbutton)
with an image as child that uses that src attribute.

(I hope I am understandable, the last part is a bit hard to explain)

> is panebutton image="" even supported? better to email ben since he hasn't
> written docs yet..
> 
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/preferences.xml#542
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/preferences.xml#921

I should say it is meant to be supported...

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 183284 [details] [diff] [review]
fix to use the correct inheritance/attribute on the pane button image

ok, makes sense, the way it works maybe doesn't make as much sense to me, but
this seems to be the right fix, as it stands.

Comment 7

[chris hofmann]

Comment on attachment 183284 [details] [diff] [review]
fix to use the correct inheritance/attribute on the pane button image

a=chofmann

Comment 8

[timeless]

Comment on attachment 183284 [details] [diff] [review]
fix to use the correct inheritance/attribute on the pane button image

mozilla/toolkit/content/widgets/preferences.xml 	1.15

Comment 9

[Teune van Steeg]

Updating the specifics for this bug for future reference