293767 - The search page does not use localised terms for statuses and resolutions

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Emmanuel Seyman]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.7) Gecko/20050416 Fedora/1.0.3-1.3.1 Firefox/1.0.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.7) Gecko/20050416 Fedora/1.0.3-1.3.1 Firefox/1.0.3

The resolution to bug #215148 introduced localised terms for statuses and
resolutions. There are quite a few areas in the Bugzilla code that need to be
modified to become aware of these translations.

This bug tracks query.cgi, where the Advanced Search will use the English terms.

Reproducible: Always

Steps to Reproduce:
1. Go to query.cgi
2. Click on "Advanced Search"


Actual Results:  
A search for is displayed using the in-DB values for statuses and resolutions.

Expected Results:  
Values for statuses and resolutions should be the values in the status_descs and
the resolution_descs from global/field-descs.none.tmpl.

Comment 1

[Emmanuel Seyman]

Attachment: two new select functions, one for statuses, one for resolutions

Couldn't find an easy way to modify the existing select function to resolve
this so I created select_status and select_resolution functions.

Comment 2

[Emmanuel Seyman]

Attachment: one select to rule them all

Talk about not seeing the forest for the trees...
One (and only one) select function.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 183391 [details] [diff] [review]
one select to rule them all

>+            [% IF name == "---" %]
>+              [% name FILTER html %]</option>
>+            [% ELSE %]
>+              [% resolution_descs.${name} FILTER html %]</option>
>+            [% END %]

This works and looks OK, but a better approach would be to add "---" to
resolution_descs and drop this conditional.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 183391 [details] [diff] [review]
one select to rule them all

After looking at the other patches you have waiting on my review, it makes more
sense to add "---" to resolution_descs.  Please update this patch with that
fix.  I'll review the other patches assuming you'll do so.

Comment 5

[Emmanuel Seyman]

Attachment: Remove the "---" special case

Taking into account Myk's comments.

This patch adds "---" to the list of translatable resolutions and removes the
escaping of the special case in the template loop.

Comment 6

[Emmanuel Seyman]

Requesting approval for this one as well.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Good low-risk polish fix for 2.20. a=myk

Comment 8

[Frédéric Buclin]

Checking in template/en/default/global/field-descs.none.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/field-descs.none.tmpl,v
 <--  field-descs.none.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/search/form.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/form.html.tmpl,v 
<--  form.html.tmpl
new revision: 1.31; previous revision: 1.30
done