The search page does not use localised terms for statuses and resolutions

RESOLVED FIXED in Bugzilla 2.20

Status

()

Bugzilla
User Interface
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Emmanuel Seyman, Assigned: Emmanuel Seyman)

Tracking

unspecified
Bugzilla 2.20
Bug Flags:
approval +

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

13 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.7) Gecko/20050416 Fedora/1.0.3-1.3.1 Firefox/1.0.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.7) Gecko/20050416 Fedora/1.0.3-1.3.1 Firefox/1.0.3

The resolution to bug #215148 introduced localised terms for statuses and
resolutions. There are quite a few areas in the Bugzilla code that need to be
modified to become aware of these translations.

This bug tracks query.cgi, where the Advanced Search will use the English terms.

Reproducible: Always

Steps to Reproduce:
1. Go to query.cgi
2. Click on "Advanced Search"


Actual Results:  
A search for is displayed using the in-DB values for statuses and resolutions.

Expected Results:  
Values for statuses and resolutions should be the values in the status_descs and
the resolution_descs from global/field-descs.none.tmpl.
(Assignee)

Comment 1

13 years ago
Created attachment 183289 [details] [diff] [review]
two new select functions, one for statuses, one for resolutions

Couldn't find an easy way to modify the existing select function to resolve
this so I created select_status and select_resolution functions.
Attachment #183289 - Flags: review?(myk)
(Assignee)

Comment 2

13 years ago
Created attachment 183391 [details] [diff] [review]
one select to rule them all

Talk about not seeing the forest for the trees...
One (and only one) select function.
Attachment #183391 - Flags: review?(myk)
(Assignee)

Updated

13 years ago
Attachment #183289 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Depends on: 215148
(Assignee)

Updated

13 years ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Updated

13 years ago
Assignee: myk → eseyman
Status: ASSIGNED → NEW
Attachment #183289 - Flags: review?(myk)
Comment on attachment 183391 [details] [diff] [review]
one select to rule them all

>+            [% IF name == "---" %]
>+              [% name FILTER html %]</option>
>+            [% ELSE %]
>+              [% resolution_descs.${name} FILTER html %]</option>
>+            [% END %]

This works and looks OK, but a better approach would be to add "---" to
resolution_descs and drop this conditional.
Attachment #183391 - Flags: review?(myk) → review+
Comment on attachment 183391 [details] [diff] [review]
one select to rule them all

After looking at the other patches you have waiting on my review, it makes more
sense to add "---" to resolution_descs.  Please update this patch with that
fix.  I'll review the other patches assuming you'll do so.
Attachment #183391 - Flags: review+ → review-
(Assignee)

Comment 5

13 years ago
Created attachment 184441 [details] [diff] [review]
Remove the "---" special case

Taking into account Myk's comments.

This patch adds "---" to the list of translatable resolutions and removes the
escaping of the special case in the template loop.
Attachment #183391 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Attachment #184441 - Flags: review?(myk)
Attachment #184441 - Flags: review?(myk) → review+
(Assignee)

Comment 6

13 years ago
Requesting approval for this one as well.
Flags: approval?
Good low-risk polish fix for 2.20. a=myk
Flags: approval? → approval+

Comment 8

13 years ago
Checking in template/en/default/global/field-descs.none.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/field-descs.none.tmpl,v
 <--  field-descs.none.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/search/form.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/form.html.tmpl,v 
<--  form.html.tmpl
new revision: 1.31; previous revision: 1.30
done
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.20
You need to log in before you can comment on or make changes to this bug.