Closed
Bug 293781
Opened 19 years ago
Closed 19 years ago
[FIXr]Add some bulletproofing to sizeToContent
Categories
(Core :: Layout, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.67 KB,
patch
|
roc
:
review+
roc
:
superreview+
asa
:
approval1.8b2+
|
Details | Diff | Splinter Review |
Right now if someone calls sizeToContent on a window that's not done parsing yet, we'll happily size it to NS_UNCONSTRAINEDSIZE twips in both directions. That seems unwanted, and generally hangs/crashes X (if nothing else, by having the OOM handling on Linux kill it).
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #183300 -
Flags: superreview?(roc)
Attachment #183300 -
Flags: review?(roc)
|
|
Assignee | |
Updated•19 years ago
|
Priority: -- → P1
Summary: Add some bulletproofing to sizeToContent → [FIX]Add some bulletproofing to sizeToContent
Target Milestone: --- → mozilla1.8beta2
Attachment #183300 -
Flags: superreview?(roc)
Attachment #183300 -
Flags: superreview+
Attachment #183300 -
Flags: review?(roc)
Attachment #183300 -
Flags: review+
|
|
Assignee | |
Updated•19 years ago
|
Summary: [FIX]Add some bulletproofing to sizeToContent → [FIXr]Add some bulletproofing to sizeToContent
|
|
Assignee | |
Comment 2•19 years ago
|
||
Comment on attachment 183300 [details] [diff] [review] Proposed patch Requesting approval. This just makes sizeToContent not create huge windows that crash X servers if it's called at the wrong time.
Attachment #183300 -
Flags: approval1.8b2?
|
||
Comment 3•19 years ago
|
||
Comment on attachment 183300 [details] [diff] [review] Proposed patch a=asa
Attachment #183300 -
Flags: approval1.8b2? → approval1.8b2+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Fixed
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•