293788 - General preferences (calendarPref.xul) not stored/preserved

Status: RESOLVED FIXED

(Calendar :: Preferences, defect)

Description

[Joey Minta]

The patch for bug 268084 introduced a regression into Sunbird.  After entering
or deleting a category, the category preferences string is not saved.  The
hidden textbox is properly updated, but the data in the prefstring is not
preserved.  The patch for bug 268084 only seems to introduce this regression in
Sunbird.  Applying the patch to .xpi builds of calendar for firefox does not
create the regression.

(Deleting a category does not work on any build due to a minor typo.  The fix
for this will be included in the patch for the above issue.)

Comment 1

[Joey Minta]

Actually, none of the normal preferences in calendarPref.xul are preserved. 
Preferences on other pages are preserved, though.

Comment 2

[Joey Minta]

I've isolated the problem to calendarPref.xul line 106.  Anyone who needs these
preferences to work should comment out that call (registerCancelCallbackFunc)
and things will return to normal.  I suspect the issue is due to some subtle
difference between pref.xul and prefBird.xul.  I'm working to try and track that
down.

(updating summary)

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

(In reply to comment #0)
> Applying the patch to .xpi builds of calendar for firefox does not
> create the regression.

It doesn't work for me on seamonkey with --enable-calendar

Comment 4

[Joey Minta]

Attachment: Tidy things up

(In reply to comment #3)
> It doesn't work for me on seamonkey with --enable-calendar

That makes sense, since seamonkeys don't fly.

The specific problem was that pref.xul and prefBird.xul don't agree on what to
call their preference services object.	This patch changes the name of
prefBird.xul's pref services object.

For the preferences window, Sunbird and Seamonkey use pref.xul.  Firefox and
Thunderbird use prefBird.xul.  Any build using pref.xul would exhibit this
regression.  In this respect prefBird and Sunbird have a naming clash.	I'd
like to at least include some documentation to clarify this, but there are no
license headers (and hence no 'Notes' section).  I also couldn't figure out who
the original authors of these files were, and didn't want to include the
headers without that.  Tell me who to give credit to and I'll add those in.

Note: In tracking this down, I also found that prefBird.xul's services are
slightly more robust than nsPrefWindow.js because prefBird.xul encloses all
registered cancelFunc's in try/catch.  Whether this hides errors that should be
found or saves programs from crashing is up for debate, but perhaps one of them
should change.

In addition, this patch tidies a few things up:
-Move repeated try/catch for backing up data to the actual backupData function
for efficiency.
-Fix typo in panelOnCancel
-Fix typo in deleteCategory
-remove extra gCategoryList.sort() calls.

I threw every test I could think of at this and it passed most of them. 
Remaining issues are:
-sort() sorts by char value, meaning "ZZZ" comes before "aaa".	I can work
around this with a manual sort, but it will be a bit slow. See also bug 278799.

-Superlong category names are a problem for this new setup.  I'd like to fix
this in the patch for bug 258555.

Comment 5

[Joey Minta]

While we're on the subject of tidying this up, should something be done about
bug 273394 which asks for wider borders to better display the color?

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in.
Other issues can be handled in other bugs. And bug 273394 isn't about the prefs,
but about the display, so i see no reason to handle it here.