2.73 KB, application/vnd.mozilla.xul+xml
1.20 KB, patch
|Details | Diff | Splinter Review|
Created attachment 183343 [details] testcase showing ways to disable radiogroups, but not all ways work The testcase is showing three ways to disable a radiogroup: 1) with the disabled attribute set to true (this doesn't work) 2) setting the disabled property to true on page load (this does work) 3) with DOM setAttribute(), removeAttribute() methodes (this doesn't work, although the disabled attribute is updated by these methodes)
Created attachment 183346 [details] [diff] [review] patch which solves the issues with the disabled attribute on radiogroups I don't know if this is the way to go with this bug, maybe it is better to solve it in nsIAccessibilityService and related interfaces. Or maybe even in nsIWidgetStateManager.js, but I don't know how that code works. Anyway I have tested this and it solves the issues whith the disabled attribute on radiogroups; it will let the testcase work. BTW this patch is for toolkit's radio.xml, but it is broken in Mozilla Suite as well as in Firefox, so I thought the Core / XP Toolkit/Widgets Component was the best place to file this bug. Should I also make a patch for xpfe or should I file a separate bug for Toolkit?
confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050527 Firefox/1.0+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Setting a radiogroup's value attribute doesn't change the selected radio button, but settings its value property does. Same goes for the disabled attribute. Currently in both cases you need extra work when writing your XUL if you want to prefill a particular value or initially disable the radiogroup, so the first part of the patch may still be acceptable.
(In reply to comment #4) <snip/> > Currently in both cases you need extra work when writing your XUL if you want > to > prefill a particular value or initially disable the radiogroup, so the first > part of the patch may still be acceptable. This is already part of radio.xml (part of patch for bug 371260): http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/radio.xml#16
Teune, is anything remaining to be done here?
You need to log in before you can comment on or make changes to this bug.