Closed Bug 293846 Opened 20 years ago Closed 20 years ago

NS_IMETHODIMP nsJSRuntimeServiceImpl::GetBackstagePass returns nsnull on failure

Categories

(Core :: XPConnect, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

()

Details

Attachments

(1 obsolete file)

149 NS_IMETHODIMP
150 nsJSRuntimeServiceImpl::GetBackstagePass(nsIXPCScriptable **bsp)
158             return nsnull;
160             return nsnull;
167             return NS_ERROR_OUT_OF_MEMORY;
170     return NS_OK;

nsXPConnect::InitClassesWithNewWrappedGlobal doesn't appreciate this (xpcshell
w/ some unhappy changes such that ssm is unhappy).
Assignee: dbradley → timeless
Status: NEW → ASSIGNED
Attachment #183347 - Flags: superreview?(shaver)
Attachment #183347 - Flags: review?(dbradley)
Comment on attachment 183347 [details] [diff] [review]
return failure code instead of null (success)

r+sr+a=shaver for wiping the earth of my shameful mistake.
Attachment #183347 - Flags: superreview?(shaver)
Attachment #183347 - Flags: superreview+
Attachment #183347 - Flags: review?(dbradley)
Attachment #183347 - Flags: review+
Attachment #183347 - Flags: approval1.8b2+
Comment on attachment 183347 [details] [diff] [review]
return failure code instead of null (success)

mozilla/js/src/xpconnect/src/xpcruntimesvc.cpp	1.18
Attachment #183347 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: