293847 - Remove dead NSS_CLASSIC code from pk11wrap

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

Recently, while going through pk11wrap looking for code that could possibly
cause invalid session handles to be used, I found myself working on DEAD code 
in pk11cert.c, code that is ifdef NSS_CLASSIC.  So, I removed all the dead
NSS_CLASSIC code from my copy of pk11cert.c and thereafter discovered that 
there was no code left that could use incalid handles.  

So, I propose that it is time for us to finally remove all NSS_CLASSIC code
from pk11wrap.  I will shortly attach a patch to do this for pk11cert.c
and will ask Bob to review it.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Targetting 3.11 with P2

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Attachment: remove NSS_CLASSIC code from pk11cert.c and pk11nobj.c

This patch removes NSS_CLASSIC code from pk11cert.c and pk11nobj.c

Comment 3

[Robert Relyea]

Comment on attachment 183348 [details] [diff] [review]
remove NSS_CLASSIC code from pk11cert.c and pk11nobj.c

r=relyea....

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Checked in above patch to pk11cert.c and pk11nobj.c.
Leaving bug open as there are more files to be done.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Presently the remaining files with NSS_CLASSIC code are:
lib/certdb/certdb.c
lib/certdb/certt.h
lib/certhigh/certhigh.c
lib/certhigh/certvfy.c

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

This was checked in for 3.11:
revision 1.5
date: 2005/08/02 01:34:38;  author: nelsonb%netscape.com;  lines: +0 -152
remove NSS_CLASSIC code from pk11cert.c and pk11nobj.c.  bug 293847  r=rrelyea